`msal-common` Performance / bypassing metadata resolution

[h3rmanj]

Core Library

MSAL.js (@azure/msal-browser)

Wrapper Library

Not Applicable

Public or Confidential Client?

Public

Documentation Location

https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-common/docs/performance.md

Description

I remember early on when using MSAL having to follow this doc to make the library bypass fetching the metadata. However, looking at the current behavior, it seems the library can assume a sane default based on some hard-coded values, and can skip metadata resolution by itself. Is this doc relevant anymore? In which scenarios would it still be beneficial to provide cloudDiscoveryMetadata and authorityMetadata?

Also, regarding this line

⚠️ It is your application's responsibility to ensure it is using correct, up-to-date cloud instance metadata. Failure to do so may result in your application not working correctly.

What is a reasonable time-frame here?

[tnorling]

This is mostly not relevant anymore. This is still there as a backup plan if a new authority gets spun up that we don't have hardcoded metadata for yet. If you're using the standard login.microsoftonline.com authority you don't need to use this anymore.

[microsoft-github-policy-service]

@@h3rmanj This issue has been automatically marked as stale because it is marked as requiring author feedback but has not had any activity for 5 days. If your issue has been resolved please let us know by closing the issue. If your issue has not been resolved please leave a comment to keep this open. It will be closed automatically in 7 days if it remains stale.

[sameerag]

@h3rmanj You can depend on the hardcoded values now as @tnorling mentioned above unless you have an IDP that needs the meta data to be set by customer, or MSAL JS needs to discover run time.

[h3rmanj]

@sameerag would you consider updating the docs to reflect current behavior?