Stop looking in localStorage for temporary cache#8579
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR removes legacy localStorage fallback behavior from BrowserCacheManager.getTemporaryCache and updates tests to match the simplified retrieval path.
Changes:
- Simplifies
getTemporaryCacheto read only from the configured temporary cache storage. - Removes the unit test that validated the legacy
localStoragefallback behavior. - Adds a changelog entry describing the behavior change.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/msal-browser/src/cache/BrowserCacheManager.ts | Removes the legacy fallback path from temporary cache reads and adds a trace log. |
| lib/msal-browser/test/cache/BrowserCacheManager.spec.ts | Deletes the test that covered the removed fallback behavior. |
| change/@azure-msal-browser-4e066b2f-6995-49dc-8d30-fb502ab69cf9.json | Records the change as a patch release note. |
lalimasharda
previously approved these changes
May 4, 2026
peterzenz
approved these changes
May 4, 2026
lalimasharda
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the behavior of the
getTemporaryCachemethod inBrowserCacheManagerby removing legacy fallback logic and updates the related unit tests accordingly. The main focus is to ensure that temporary cache retrieval is streamlined and no longer checks local storage for items set by old versions.Fixes #8577
Browser cache logic simplification:
BrowserCacheManager.ts: Removed fallback logic ingetTemporaryCachethat previously checkedlocalStoragefor temporary cache items if not found in session/memory storage. The method now only checks the intended temporary cache storage. Added a trace log for method invocation.Test updates:
BrowserCacheManager.spec.ts: Removed the test that verified fallback tolocalStorageingetTemporaryCache, as this behavior is no longer supported.