Update docs with popup closure detection and interaction status details#8580
Merged
konstantin-msft merged 5 commits intodevfrom May 4, 2026
Merged
Update docs with popup closure detection and interaction status details#8580konstantin-msft merged 5 commits intodevfrom
konstantin-msft merged 5 commits intodevfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates MSAL Browser documentation to clarify how popup/iframe authentication responses are received (BroadcastChannel), how manual popup closure is handled, and how to configure the related timeouts.
Changes:
- Added a new section explaining popup closure detection behavior and how it affects
InteractionStatusand emitted events. - Documented new configuration options
popupBridgeTimeoutandiframeBridgeTimeout, with defaults and expected error behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/msal-browser/docs/login-user.md | Adds guidance on popup closure behavior, timeout-driven failure, and retry guidance via overrideInteractionInProgress. |
| lib/msal-browser/docs/configuration.md | Documents new timeout configuration settings tied to BroadcastChannel-based response handling. |
tnorling
reviewed
May 4, 2026
Co-authored-by: Thomas Norling <thomas.norling@microsoft.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
tnorling
approved these changes
May 4, 2026
peterzenz
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the MSAL Browser documentation to reflect changes in how popup and iframe authentication timeouts are handled, and provides new guidance on detecting popup closure events. The most important changes are grouped below:
Configuration and Timeout Options:
lib/msal-browser/docs/configuration.mdto remove legacy timeout options (windowHashTimeout,iframeHashTimeout,loadFrameTimeout,navigateFrameWait, andpollIntervalMilliseconds) and add new options:popupBridgeTimeout(for popups, default 60s) andiframeBridgeTimeout(for hidden iframes, default 10s), both related to BroadcastChannel-based communication.Popup Closure Handling and User Experience:
lib/msal-browser/docs/login-user.mdexplaining how popup closure detection now works using BroadcastChannel, the resulting user experience when a popup is closed (including delayed error handling andInteractionStatusbehavior), and how to allow users to retry login immediately using theoverrideInteractionInProgressflag.