Updating config for RX/EX clouds endpoints#8581
Closed
segannon wants to merge 2 commits intoAzureAD:devfrom
Closed
Updating config for RX/EX clouds endpoints#8581segannon wants to merge 2 commits intoAzureAD:devfrom
segannon wants to merge 2 commits intoAzureAD:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates msal-common authority configuration to recognize additional Azure Government cloud hosts (US Secret / US Top Secret) across hardcoded authority metadata and test constants.
Changes:
- Add US Secret (
login.microsoftonline.microsoft.scloud) and US Top Secret (login.microsoftonline.eaglex.ic.gov) hosts/aliases to hardcoded instance discovery and endpoint metadata. - Expose new
AzureCloudInstanceentries for the two additional clouds. - Extend test-kit cloud host/alias constants to include the new clouds.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/msal-common/test/test_kit/StringConstants.ts | Adds new cloud host constants and expected alias mappings for test coverage of the new environments. |
| lib/msal-common/src/authority/AuthorityOptions.ts | Exposes new AzureCloudInstance values for US Secret and US Top Secret cloud authorities. |
| lib/msal-common/src/authority/AuthorityMetadata.ts | Adds new hosts to hardcoded endpoint metadata and instance discovery metadata so they are treated as known Microsoft authorities. |
casing for standardization Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update config for AGC clouds