Use unsigned redirect uri for mac broker flows

Author: fengga

msal/broker.py

@@ -52,6 +52,8 @@ class TokenTypeError(ValueError):
     # so they have to use a generic placeholder anyway.
     # The v-team chose to combine two situations into using same placeholder.
 
+_redirect_uri_on_linux = "https://login.microsoftonline.com/common/oauth2/nativeclient"
+
 
 def _convert_error(error, client_id):
     context = error.get_context()  # Available since pymsalruntime 0.0.4
@@ -145,20 +147,19 @@ def _build_msal_runtime_auth_params(client_id, authority):
     params.set_additional_parameter("msal_client_ver", __version__)
     return params
 
-def _set_redirect_uri_for_linux(params):
+def _set_redirect_uri(params):
     if sys.platform == "linux":
-        # This is required by Linux Java Broker to set a non-empty valid redirect_uri
-        params.set_redirect_uri(
-            "https://login.microsoftonline.com/common/oauth2/nativeclient"
-        )
+        params.set_redirect_uri(_redirect_uri_on_linux)
+    elif sys.platform == "darwin":
+        params.set_redirect_uri(_redirect_uri_on_mac)
 
 def _signin_silently(
         authority, client_id, scopes, correlation_id=None, claims=None,
         enable_msa_pt=False,
         auth_scheme=None,
         **kwargs):
     params = _build_msal_runtime_auth_params(client_id, authority)
-    _set_redirect_uri_for_linux(params)
+    _set_redirect_uri(params)
     params.set_requested_scopes(scopes)
     if claims:
         params.set_decoded_claims(claims)
@@ -193,12 +194,7 @@ def _signin_interactively(
         **kwargs):
     params = _build_msal_runtime_auth_params(client_id, authority)
     params.set_requested_scopes(scopes)
-    params.set_redirect_uri(
-        _redirect_uri_on_mac if sys.platform == "darwin" else
-        "https://login.microsoftonline.com/common/oauth2/nativeclient"
-        # This default redirect_uri value is not currently used by WAM
-        # but it is required by the MSAL.cpp to be set to a non-empty valid URI.
-    )
+    _set_redirect_uri(params)
     if prompt:
         if prompt == "select_account":
             if login_hint:
@@ -248,7 +244,7 @@ def _acquire_token_silently(
     if account is None:
         return
     params = _build_msal_runtime_auth_params(client_id, authority)
-    _set_redirect_uri_for_linux(params)
+    _set_redirect_uri(params)
     params.set_requested_scopes(scopes)
     if claims:
         params.set_decoded_claims(claims)