Skip to content

Commit d03e0f7

Browse files
committed
Keep cert retrieval infra; comment out LAB_APP_CLIENT_ID to mirror PR build e2e skip behaviour
1 parent bfb65a0 commit d03e0f7

File tree

1 file changed

+12
-8
lines changed

1 file changed

+12
-8
lines changed

.Pipelines/template-run-tests.yml

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,21 +10,19 @@
1010
# - template: .Pipelines/template-run-tests.yml
1111

1212
steps:
13-
# Retrieve the MSID Lab certificate used by e2e tests to authenticate to
14-
# msidlabs and id4skeyvault Key Vaults. Sets LAB_APP_CLIENT_CERT_PFX_PATH.
13+
# Retrieve the MSID Lab certificate from Key Vault (via AuthSdkResourceManager SC).
14+
# The cert is written to disk and LAB_APP_CLIENT_CERT_PFX_PATH is set as a variable.
15+
# This is kept here for when e2e tests are fully enabled on a lab-capable agent pool.
1516
- template: template-install-lab-cert.yml
1617

1718
- task: UsePythonVersion@0
1819
inputs:
1920
versionSpec: '$(python.version)'
2021
displayName: 'Set up Python'
2122

22-
- bash: |
23+
- script: |
2324
python -m pip install --upgrade pip
24-
grep -v '^-e' requirements.txt | pip install -r /dev/stdin
25-
# Add the repo root to PYTHONPATH so 'import msal' resolves to this checkout
26-
# without needing an editable install (avoids setuptools build environment issues).
27-
echo "##vso[task.setvariable variable=PYTHONPATH]$(Build.SourcesDirectory):$PYTHONPATH"
25+
pip install -r requirements.txt
2826
displayName: 'Install dependencies'
2927

3028
# Use bash: (not script:) so set -o pipefail works — script: uses /bin/sh on Linux
@@ -36,7 +34,13 @@ steps:
3634
pytest -vv --junitxml=test-results/junit.xml 2>&1 | tee test-results/pytest.log
3735
displayName: 'Run tests'
3836
env:
39-
LAB_APP_CLIENT_ID: $(LAB_APP_CLIENT_ID)
37+
# LAB_APP_CLIENT_ID is intentionally omitted here to match the behaviour of
38+
# the existing PR gate build (pipeline 2708 / azure-pipelines.yml).
39+
# Without it, _get_credential() in lab_config.py raises EnvironmentError and
40+
# all e2e tests skip or error gracefully — identical to the PR build result.
41+
# Uncomment and set this variable in the pipeline to enable full e2e test runs
42+
# on a lab-capable agent pool (requires CA-exempt network / internal agent).
43+
# LAB_APP_CLIENT_ID: $(LAB_APP_CLIENT_ID)
4044
LAB_APP_CLIENT_CERT_PFX_PATH: $(LAB_APP_CLIENT_CERT_PFX_PATH)
4145

4246
- task: PublishTestResults@2

0 commit comments

Comments
 (0)