Implement correct metadata interface for RequiredScopeOrAppPermission extension method#3352
Merged
jmprieur merged 3 commits intoMay 15, 2025
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
evan-buss
force-pushed
the
fix/3323-scope-or-app-permission-extension
branch
from
481dd2f to
4e977d9
Compare
evan-buss
force-pushed
the
fix/3323-scope-or-app-permission-extension
branch
from
893eba1 to
3e47595
Compare
jmprieur
approved these changes
May 15, 2025
Collaborator
jmprieur
left a comment
jmprieur
left a comment
There was a problem hiding this comment.
LGTM
Thanks @evan-buss
kllysng
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
RequiredScopeOrAppPermissionMetadataclass to implementIAuthRequiredScopeOrAppPermissionMetadatarather thanIAuthRequiredScopeMetadata. This makes it conform to the type that theScopeOrAppPermissionAuthorizationHandlerlooks for in order to determine what scopes and app permissions to check for.Description
Also added a new unit test file that tests the extension method by creating an endpoint with the appropriate metadata. This test fails when you swap back to
IAuthRequiredScope.Fixes #3323