From 756f8ac7ef42352b17f43d226f631beb0d3a3751 Mon Sep 17 00:00:00 2001 From: Iarek Kovtunenko <16271112+iarekk@users.noreply.github.com> Date: Mon, 13 Jul 2026 12:19:55 +0100 Subject: [PATCH] Remove redundant 'Run unit tests' GitHub Action The ADO PR pipeline now runs the full unit test matrix (incl. net462/472) after #3935, making the dotnetcore.yml GitHub Action redundant. Remove it and rely on the ADO check for PR validation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .github/workflows/dotnetcore.yml | 94 -------------------------------- 1 file changed, 94 deletions(-) delete mode 100644 .github/workflows/dotnetcore.yml diff --git a/.github/workflows/dotnetcore.yml b/.github/workflows/dotnetcore.yml deleted file mode 100644 index df2dc7df8..000000000 --- a/.github/workflows/dotnetcore.yml +++ /dev/null @@ -1,94 +0,0 @@ -name: "Run unit tests" - -permissions: - contents: read - pull-requests: write - -on: - push: - branches: - - master - pull_request: - types: - - opened - - synchronize - - reopened - - ready_for_review - branches: - - master - -env: - TargetNetNext: 'False' - -jobs: - build: - runs-on: windows-latest - continue-on-error: false - name: "Build and run unit tests" - steps: - - name: Checkout repository - uses: actions/checkout@v5 - - - - - name: Setup .NET 9.0.x - uses: actions/setup-dotnet@v5 - with: - dotnet-version: 9.0.x - - - name: Setup .NET 10.0.x - uses: actions/setup-dotnet@v5 - with: - dotnet-version: 10.0.x - - - name: 'Setup MSBuild' - uses: microsoft/setup-msbuild@v2 - with: - msbuild-architecture: x64 - - - name: Setup wasm-tools - run: dotnet workload install wasm-tools - - - name: Build solution - run: dotnet msbuild Microsoft.Identity.Web.sln -r -t:build -verbosity:m -property:Configuration=Release - - - name: Test with .NET 8.0.x - run: dotnet test --no-restore --no-build Microsoft.Identity.Web.sln -f net8.0 -v m -p:FROM_GITHUB_ACTION=true --configuration Release --collect "Xplat Code Coverage" --filter "(FullyQualifiedName!~Microsoft.Identity.Web.Test.Integration)&(FullyQualifiedName!~WebAppUiTests)&(FullyQualifiedName!~IntegrationTests)&(FullyQualifiedName!~TokenAcquirerTests)&(FullyQualifiedName!~AgentApplicationsTests)" - - - name: Test with .NET 9.0.x - run: dotnet test --no-restore --no-build Microsoft.Identity.Web.sln -f net9.0 -v m -p:FROM_GITHUB_ACTION=true --configuration Release --collect "Xplat Code Coverage" --filter "(FullyQualifiedName!~Microsoft.Identity.Web.Test.Integration)&(FullyQualifiedName!~WebAppUiTests)&(FullyQualifiedName!~IntegrationTests)&(FullyQualifiedName!~TokenAcquirerTests)&(FullyQualifiedName!~AgentApplicationsTests)&(FullyQualifiedName!~SidecarEndpointsE2ETests)" - - - - name: Test with .NET 10.0.x - run: dotnet test --no-restore --no-build Microsoft.Identity.Web.sln -f net10.0 -v m -p:FROM_GITHUB_ACTION=true --configuration Release --collect "Xplat Code Coverage" --filter "(FullyQualifiedName!~Microsoft.Identity.Web.Test.Integration)&(FullyQualifiedName!~WebAppUiTests)&(FullyQualifiedName!~IntegrationTests)&(FullyQualifiedName!~TokenAcquirerTests)&(FullyQualifiedName!~SidecarEndpointsE2ETests)" - - - name: Create code coverage report - run: | - dotnet tool install -g dotnet-reportgenerator-globaltool --version 5.4.1 - reportgenerator -reports:./**/coverage.cobertura.xml -targetdir:CodeCoverage -reporttypes:'MarkdownSummaryGithub;Cobertura' -filefilters:'+src/**/*.cs' - - # - name: Write coverage to job summary - # shell: bash - # run: | - # cat CodeCoverage/SummaryGithub.md >> $GITHUB_STEP_SUMMARY - # echo "COMMENT_CONTENT_ENV_VAR<> $GITHUB_ENV - # echo $(cat CodeCoverage/SummaryGithub.md) >> $GITHUB_ENV - # echo "EOF" >> $GITHUB_ENV - - # - name: Comment coverage in PR - # uses: actions/github-script@v7 - # id: comment - # with: - # script: | - # github.rest.issues.createComment({ - # issue_number: context.issue.number, - # owner: context.repo.owner, - # repo: context.repo.repo, - # body: process.env.COMMENT_CONTENT_ENV_VAR - # }) - - - name: Test with .NET 462 - run: dotnet test --no-restore --no-build Microsoft.Identity.Web.sln -f net462 -v normal -p:FROM_GITHUB_ACTION=true --configuration Release --filter "(FullyQualifiedName!~Microsoft.Identity.Web.Test.Integration)&(FullyQualifiedName!~WebAppUiTests)&(FullyQualifiedName!~IntegrationTests)&(FullyQualifiedName!~AgentApplicationsTests)" - - - name: Test with .NET 472 - run: dotnet test --no-restore --no-build Microsoft.Identity.Web.sln -f net472 -v normal -p:FROM_GITHUB_ACTION=true --configuration Release --filter "(FullyQualifiedName!~Microsoft.Identity.Web.Test.Integration)&(FullyQualifiedName!~WebAppUiTests)&(FullyQualifiedName!~IntegrationTests)&(FullyQualifiedName!~AgentApplicationsTests)"