Skip to content

handle 'ResourceGroupNotFound' in connectedk8s delete by skipping ARM…#38

Open
bavneetsingh16 wants to merge 4 commits intomainfrom
tolerate_missing_rg
Open

handle 'ResourceGroupNotFound' in connectedk8s delete by skipping ARM…#38
bavneetsingh16 wants to merge 4 commits intomainfrom
tolerate_missing_rg

Conversation

@bavneetsingh16
Copy link
Copy Markdown

… deletion


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 4, 2026

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

try:
cluster_resource = client.get(resource_group_name, cluster_name)
except HttpResponseError as ex:
# If the resource group or cluster resource is not found, proceed with local cleanup
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to check if the resource group and resource name tallies with the one being deleted. I dont see the check , can you please add or point me to it ?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error check is only for handling ARM call failing, the delete flow still remains the same.

The existing resource check:
https://github.com/AzureArcForKubernetes/connectedk8s/blob/main/src/connectedk8s/azext_connectedk8s/custom.py#L1984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants