handle 'ResourceGroupNotFound' in connectedk8s delete by skipping ARM…#38
handle 'ResourceGroupNotFound' in connectedk8s delete by skipping ARM…#38bavneetsingh16 wants to merge 4 commits intomainfrom
Conversation
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
| try: | ||
| cluster_resource = client.get(resource_group_name, cluster_name) | ||
| except HttpResponseError as ex: | ||
| # If the resource group or cluster resource is not found, proceed with local cleanup |
There was a problem hiding this comment.
we need to check if the resource group and resource name tallies with the one being deleted. I dont see the check , can you please add or point me to it ?
There was a problem hiding this comment.
This error check is only for handling ARM call failing, the delete flow still remains the same.
The existing resource check:
https://github.com/AzureArcForKubernetes/connectedk8s/blob/main/src/connectedk8s/azext_connectedk8s/custom.py#L1984
… deletion
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.