Skip to content

Adding CLI Configuration for DisableInformerCache Flag#1

Closed
mayankagg9722 wants to merge 1 commit into
AzureArcForKubernetes:mainfrom
mayankagg9722:main
Closed

Adding CLI Configuration for DisableInformerCache Flag#1
mayankagg9722 wants to merge 1 commit into
AzureArcForKubernetes:mainfrom
mayankagg9722:main

Conversation

@mayankagg9722
Copy link
Copy Markdown

This is required for our helm charts where customers can opt to change the caching behaviour during restore.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Create command:

az k8s-extension create --name azure-aks-backup --extension-type Microsoft.DataProtection.Kubernetes --scope cluster --cluster-name p1a-scaleTest-cluster --resource-group priyansh-p1a --cluster-type managedClusters --release-train stable --configuration-settings blobContainer=extension-aks storageAccountResourceGroup=priyansh-p1a storageAccount=p1ascalesa storageAccountSubscriptionId=a54fc8c4-a7cd-4ae1-b404-b2c317c2e58c disableInformerCache=true cpuRequest=1000m cpuLimit=1200m memoryRequest=300Mi memoryLimit=1800Mi

Update Command

az k8s-extension update --name azure-aks-backup --cluster-name p1a-scaleTest-cluster --resource-group priyansh-p1a --cluster-type managedClusters --release-train stable --configuration-settings blobContainer=extension-aks storageAccountResourceGroup=priyansh-p1a storageAccount=p1ascalesa storageAccountSubscriptionId=a54fc8c4-a7cd-4ae1-b404-b2c317c2e58c disableInformerCache=true cpuRequest=1000m cpuLimit=1200m memoryRequest=300Mi memoryLimit=1800Mi

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

This is required for our helm charts where customers can opt to change the caching behaviour during restore.
@github-actions
Copy link
Copy Markdown

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Copy Markdown

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

bavneetsingh16 pushed a commit that referenced this pull request Feb 4, 2026
…ommands for replication (Azure#9493)

* Adding "Migrate" folder to the project

* Added migrate command

* Adding preview tag for commands, moving migration to a seperate folder & update help text.

* Addressing style issues

* addressing the styles and removing the duplicate key

* addressing style issues

* addesssing more style issues

* addressing  inline disable at the specific line

* Added R1702 to the pylint disable comment on the function definition.

* Addressing to disable too many nested blocks R1702

* Fixing test cases and updating version changes

* Add cli fixes (#1)

* Create extension

* Update src/migrate/azext_migrate/__init__.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fix import issues

* Update src/migrate/setup.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Small

* Small lint

* Small

* disable lint for this check

* Add json

* Fix licesnse issue

* fix small

* Small

* Get rid of unused variables

* Add service name and code owner

* New version

* Style

* Small

* Update

* Follow standard

* Add suggestions

* Small

* Not preview

* Add flag to become experimental

* Update history

* Fix

* small

* Create get job and remove replication commands

* Add better error handling for jobs command

* Add better messages to remove protected item

* Return job id in remove command

* Move helpers

* Rename get discovered server helper

* Refactor _initialize_replication_infrastructure_helpers

* Refactor new replication

* Refactor jobs

* Refactor delete protected item

* Fix lint issues

* Change release version

* Fix lint issues

* Add fix

* Updae correct version

* Put beta version before

* Fix

* Update

* Fix bifurcation tool issue

* Update amh correctly if not proper

* Use current subscription id if not passed in

* Fix correct location and target resource group creation

* Create list protected items command

* Update versions

* Add __init__.py to all folders

* Create unit tests for get replication

* Update readme with accurate description of commands

* Update readme

* Create tests for jobs and remove commands

* Add more tests to increase coverage to 74%

* Add start migration command

* Address fixes

* Remove doc strings from custom.py

* Add init

* Remove old file locations

* fix failing tests

* Fix secret test

* Fix test

* Fix secret detection

* Fix duplicates

---------

Co-authored-by: Saif Al-Din Ali <saifaldinali@microsoft.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Saif Al-Din Ali <saif-canada@hotmail.com>
Co-authored-by: Saif Al-Din Ali <saifaldinali@microsoft.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants