test framework v2 fixes and updates from iot-device-telemetry java run#122
Closed
TheovanKraay wants to merge 3 commits intoAzureCosmosDB:mainfrom
Closed
test framework v2 fixes and updates from iot-device-telemetry java run#122TheovanKraay wants to merge 3 commits intoAzureCosmosDB:mainfrom
TheovanKraay wants to merge 3 commits intoAzureCosmosDB:mainfrom
Conversation
…ency Agent-Logs-Url: https://github.com/TheovanKraay/cosmosdb-agent-kit/sessions/e4b1c91e-25fd-4f73-9c58-57f817e866fe Co-authored-by: TheovanKraay <24420698+TheovanKraay@users.noreply.github.com>
…try-skills batch: iot-device-telemetry aggregate results — skills loaded (java)
Contributor
Author
|
@copilot rules have been updated but SKILL.md has not, please update. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Cosmos DB best-practices skill set and testing artifacts based on insights from the iot-device-telemetry Java batch run (#232), adding new query guidance and refining existing rules.
Changes:
- Added two new query best-practice rules for deterministic “latest” reads and single-pass aggregate stats.
- Clarified/expanded existing rules around schema versioning and point-read usage (parent existence validation).
- Added batch #232 result artifacts and logged the evaluation in
IMPROVEMENTS-LOG.md; regeneratedAGENTS.md.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| testing-v2/scenarios/iot-device-telemetry/batch-results/batch-232-java-skills.md | Adds human-readable summary of batch #232 results. |
| testing-v2/scenarios/iot-device-telemetry/batch-results/batch-232-java-skills.json | Adds machine-readable batch #232 results for analysis. |
| testing-v2/IMPROVEMENTS-LOG.md | Records batch #232 findings and documents rule changes (but currently includes malformed table rows that need fixing). |
| skills/cosmosdb-best-practices/rules/query-point-reads.md | Adds guidance to validate parent existence via point read prior to writing child/event docs. |
| skills/cosmosdb-best-practices/rules/query-latest-by-timestamp.md | New rule documenting ORDER BY <timestamp> DESC + TOP 1 for deterministic latest-item queries. |
| skills/cosmosdb-best-practices/rules/query-aggregate-single-pass.md | New rule recommending single-pass MIN/MAX/AVG aggregation with consistent filters. |
| skills/cosmosdb-best-practices/rules/model-schema-versioning.md | Clarifies schemaVersion should be applied to every persisted document type. |
| skills/cosmosdb-best-practices/AGENTS.md | Regenerated compiled rules doc to include new/updated rules and updated TOC numbering. |
Comment on lines
54
to
+56
| | Category | Pass Rate (when startup works) | | ||
| |----------|-------------------------------| | ||
| | 2026-04-18 | iot-device-telemetry | Batch #232 (skills, java) | Aggregated 5 iterations | See batch-results/ | |
| @@ -0,0 +1,157 @@ | |||
| # Batch Test Results: Iot Device Telemetry | |||
|
|
||
| | Metric | Value | | ||
| |--------|-------| | ||
| | 2026-04-18 | iot-device-telemetry | Batch #232 (skills, java) | Aggregated 5 iterations | See batch-results/ | |
|
|
||
| | Metric | Value | | ||
| |--------|-------| | ||
| | 2026-04-18 | iot-device-telemetry | Batch #232 (skills, java) | Aggregated 5 iterations | See batch-results/ | |
Comment on lines
106
to
+108
| | Test | Pass Rate | Pattern | | ||
| |------|-----------|---------| | ||
| | 2026-04-18 | iot-device-telemetry | Batch #232 (skills, java) | Aggregated 5 iterations | See batch-results/ | |
Comment on lines
249
to
253
| **Score Improvement Trend**: | ||
| | Iteration | Language | Score | Key Issues | | ||
| |-----------|----------|-------|------------| | ||
| | 2026-04-18 | iot-device-telemetry | Batch #232 (skills, java) | Aggregated 5 iterations | See batch-results/ | | ||
| | 2026-04-01 | gaming-leaderboard | Batch #191 (skills, python) | Aggregated 5 iterations | See batch-results/ | |
|
|
||
| | Aspect | Iter-001 (.NET) | Iter-002 (Java) | Delta | | ||
| |--------|----------------|----------------|-------| | ||
| | 2026-04-18 | iot-device-telemetry | Batch #232 (skills, java) | Aggregated 5 iterations | See batch-results/ | |
Comment on lines
+1184
to
1185
| | 2026-04-18 | iot-device-telemetry | Batch #232 (skills, java) | Aggregated 5 iterations | See batch-results/ | | ||
| | 2026-04-01 | gaming-leaderboard | Batch #191 (skills, python) | Aggregated 5 iterations | See batch-results/ | |
Comment on lines
+16
to
+17
| CosmosPagedIterable<JsonNode> page = container.queryItems( | ||
| "SELECT * FROM c WHERE c.deviceId = @deviceId", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Checklist
npm run validateand it passednpm run buildto regenerate AGENTS.md (if adding/updating rules){prefix}-{description}.mdtitle,impact,tags)For New Rules
Rule file:
skills/cosmosdb-best-practices/rules/_____.mdCategory:
Impact level:
Why is this rule important?
Testing
Related Issues
Additional Notes