Add readItem() / CosmosItemResponse unwrapping guidance to sdk-java-content-response rule#38
Merged
TheovanKraay merged 3 commits intoMar 23, 2026
Conversation
…a-content-response rule Fixes #27: Code treating CosmosItemResponse<T> as T directly — missing .getItem() call caused type mismatch compilation errors at every readItem() call site (~30% of raw-SDK runs). - Updated rule title, tags, and impact description for broader scope - Added new leading section with incorrect/correct examples (sync + async) - Recompiled AGENTS.md - Updated IMPROVEMENTS-LOG.md Co-authored-by: TheovanKraay <24420698+TheovanKraay@users.noreply.github.com> Agent-Logs-Url: https://github.com/AzureCosmosDB/cosmosdb-agent-kit/sessions/e4d08924-00f7-452c-b90c-987c2eafd29c
Copilot
AI
changed the title
[WIP] Add readItem() unwrapping guidance for CosmosItemResponse in Java SDK
Add readItem() / CosmosItemResponse<T> unwrapping guidance to sdk-java-content-response rule
Mar 23, 2026
Contributor
|
@copilot we don't need to update the improvements log, that is only for changes implemented via the testing frameworks within this repo. These are separately analysed changes via SCOPE testing (a separate tool). remove the log updates. |
… changes Co-authored-by: TheovanKraay <24420698+TheovanKraay@users.noreply.github.com> Agent-Logs-Url: https://github.com/AzureCosmosDB/cosmosdb-agent-kit/sessions/728b5aea-f2c7-4e91-9d77-cefe9ac0a9b9
Contributor
Author
Copilot
AI
changed the title
Add readItem() / CosmosItemResponse<T> unwrapping guidance to sdk-java-content-response rule
Add readItem() / CosmosItemResponse unwrapping guidance to sdk-java-content-response rule
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
~30% of raw-SDK Java runs treat
CosmosItemResponse<T>asTdirectly onreadItem()calls, missing.getItem()— causing compilation failures. The existing rule only covered write-side (contentResponseOnWriteEnabled); this extends it to cover read-side unwrapping.Rule changes (
sdk-java-content-response.md)readItem()unwrappingCosmosItemResponse<T>Key pattern added
Other files
AGENTS.md— recompiledOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.