Fix GetPropertyValue to support nested partition key paths#230
Merged
markjbrown merged 4 commits intomainfrom Jan 5, 2026
Merged
Fix GetPropertyValue to support nested partition key paths#230markjbrown merged 4 commits intomainfrom
markjbrown merged 4 commits intomainfrom
Conversation
Co-authored-by: philnach <19275540+philnach@users.noreply.github.com>
…duplication Co-authored-by: philnach <19275540+philnach@users.noreply.github.com>
Co-authored-by: philnach <19275540+philnach@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Cosmos Data Extension GetPropertyValue failure with nested keys
Fix GetPropertyValue to support nested partition key paths
Jan 4, 2026
philnach
approved these changes
Jan 4, 2026
Collaborator
philnach
left a comment
There was a problem hiding this comment.
This looks good to me and I agree with the testing strategy.
markjbrown
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
GetPropertyValuemethod fails when partition keys reference nested object properties (e.g.,/partitionkeyvalue1/partitionkeyvalue2). It attempts a direct dictionary lookup using the full path as a key instead of traversing the nested structure.Changes
Modified
GetPropertyValueinCosmosDataSinkExtension.cs/and traverse nested ExpandoObjects sequentiallyAdded test coverage in
CosmosDataSinkExtensionTests.csExample
Given a document:
{ "id": "123", "partitionkeyvalue1": { "partitionkeyvalue2": "abc-guid", "otherField": "data" } }With partition key path
/partitionkeyvalue1/partitionkeyvalue2, the method now correctly navigates toitem["partitionkeyvalue1"]["partitionkeyvalue2"]and returns"abc-guid"instead of throwingKeyNotFoundException.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.