Skip to content

modified parameter.json: units in keys and isogeometric elements#86

Merged
div-tyg merged 7 commits into
mainfrom
84-units
May 21, 2026
Merged

modified parameter.json: units in keys and isogeometric elements#86
div-tyg merged 7 commits into
mainfrom
84-units

Conversation

@div-tyg

@div-tyg div-tyg commented May 18, 2026

Copy link
Copy Markdown
Collaborator

Changes:

  • units in keys.
  • Isogeometric elements
  • new output mterics (no. of DOFs and max. displacement error at nodes).

@div-tyg div-tyg linked an issue May 18, 2026 that may be closed by this pull request
@div-tyg div-tyg requested a review from joergfunger May 19, 2026 11:15

@joergfunger joergfunger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks almost good to me, I would significantly change/add a sensor configuration layout. I'm only not sure where to place that. We could either add it to the parameter.json, or we add that to a tool_specific parameter_file (since I'm not sure everyone will be able to use it. Or we add another sensor.json? Any ideas?

Comment thread examples/linear-elastic-plate-with-hole/fenics/run_simulation.py Outdated
Comment thread examples/linear-elastic-plate-with-hole/fenics/run_simulation.py Outdated
Comment thread examples/linear-elastic-plate-with-hole/fenics/run_simulation.py Outdated
Comment thread examples/linear-elastic-plate-with-hole/fenics/run_simulation.py Outdated
Comment thread examples/linear-elastic-plate-with-hole/fenics/run_simulation.py
Comment thread examples/linear-elastic-plate-with-hole/kratos/create_kratos_input.py Outdated
Comment thread examples/linear-elastic-plate-with-hole/kratos/create_kratos_input.py Outdated
Comment thread examples/linear-elastic-plate-with-hole/kratos/create_kratos_input.py Outdated

@joergfunger joergfunger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure that all changes that are made here are actually transferred to the new repo, including the changes in the markdown files. @div-tyg please merge the branch into main yourself (and directly delete the branch - there is a button in github right after you have done the merge).

@div-tyg div-tyg merged commit 19e24c3 into main May 21, 2026
12 checks passed
@div-tyg div-tyg deleted the 84-units branch May 21, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

units

3 participants