Skip to content

fix(build): resolve relative paths and preserve zip execute bits (#217) #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BANANASJIM merged 1 commit into from
Apr 16, 2026
Merged

fix(build): resolve relative paths and preserve zip execute bits (#217) #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/rdc/_build_renderdoc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,10 @@ def _safe_extractall(zf: zipfile.ZipFile, dest: Path) -> None:
sys.stderr.write(f"ERROR: zip-slip attempt detected: {member.filename}\n")
raise SystemExit(1)
zf.extract(member, dest)
# Restore Unix execute bits that zipfile.extract() drops.
unix_mode = member.external_attr >> 16
if unix_mode and (unix_mode & 0o111):
target.chmod(target.stat().st_mode | (unix_mode & 0o111))


def download_swig(build_dir: Path) -> None:
Expand Down Expand Up @@ -756,8 +760,10 @@ def main(argv: list[str] | None = None) -> None:
args = parser.parse_args(argv)

plat = _platform()
install_dir = Path(args.install_dir) if args.install_dir else default_install_dir()
build_dir = Path(args.build_dir) if args.build_dir else install_dir.parent / "renderdoc-build"
install_dir = Path(args.install_dir).resolve() if args.install_dir else default_install_dir()
build_dir = (
Path(args.build_dir).resolve() if args.build_dir else install_dir.parent / "renderdoc-build"
)

if _artifacts_present(install_dir, plat):
_log(f"renderdoc already exists at {install_dir}/")
Expand Down
Loading