Skip to content

Commit 2911ca9

Browse files
committed
fix(dialog-editor): stop the selected-option inspector collapsing into one grey blob
In the focused-option view the option row (.trow.choicesel) painted a full-row background of --vscode-list-inactiveSelectionBackground. In bgforge-monokai that token equals --vscode-input-background (both #414339), so the row, every field's own background, and the fields' borders were all the identical grey: the input boxes had no visible edge and the panel read as bare text floating on one grey blob, with no form structure. The node view was unaffected only because its rows are not selection-washed, so the field backgrounds stand out against the darker panel. Drop the full-row fill; the focus-accent left border, the tree-row highlight, and the "option #N" crumb already mark the selected option. Field backgrounds now sit on the dark inspector panel (rgb 30,31,28 vs field rgb 65,67,57) and render as distinct boxes again.
1 parent ec45b2c commit 2911ca9

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

client/src/dialog-editor/webview/Inspector.svelte

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -780,11 +780,14 @@
780780
flex-direction: column;
781781
gap: 3px;
782782
}
783-
/* The option selected from the tree: focus-accented left border + faint fill, matching the tree row's
784-
selection, so the same option reads as selected in both panels. */
783+
/* The option selected from the tree: a focus-accented left border marks it. Do NOT add a full-row
784+
background fill here: list-inactiveSelectionBackground equals input-background in some themes
785+
(bgforge-monokai: both #414339), so a fill paints the row the SAME colour as every field's own
786+
background - the field boxes, their borders, and the row all collapse into one grey blob and the form
787+
structure disappears (labels + values become bare text on grey). The left accent, the tree-row
788+
highlight, and the "option #N" crumb carry the selection without touching field backgrounds. */
785789
.trow.choicesel {
786790
border-left-color: var(--vscode-focusBorder);
787-
background: var(--vscode-list-inactiveSelectionBackground);
788791
}
789792
.trhead {
790793
display: flex;

0 commit comments

Comments
 (0)