Spatial_Engine: Mirror implemented for IElements#3579
Conversation
|
Thanks for the review @peterjamesnugent, I've addressed all comments, also expanded the test script - would be great if you could have another look and address two things:
...once this is done, I will update |
|
@BHoMBot check compliance |
|
@pawelbaran to confirm, the following actions are now queued:
|
|
Please be advised that the check with reference 82350084431 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 7 additional annotations waiting, made up of 0 errors and 7 warnings. |
|
@pawelbaran to confirm, the following actions are now queued:
|
|
Please be advised that the check with reference 82371330239 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 7 additional annotations waiting, made up of 0 errors and 7 warnings. |
peterjamesnugent
left a comment
There was a problem hiding this comment.
Approving after compliance fixes.
Issues addressed by this PR
Closes #3578
Test files
On SharePoint
Changelog
Additional comments
The code has been built based on the assumption that all transformations (translation, rotation, mirror, shear) should default down to
Transformmethods being called from within. This is exactly what is being done in this PR, requirement for transform methods being loosened to allow pure reflection.Following the above, there is no need for extensive tests because literally all spatial mirrors will call
Transform- if the latter is fine, we're good.