Fix json decode error in Walkability, and compliance (#343)

Author: jamesramsden-bh

…ybugTools_Engine/Compute/SimulationId.cs …ybugTools_Engine/Compute/SimulationID.csLadybugTools_Engine/Compute/SimulationId.cs renamed to LadybugTools_Engine/Compute/SimulationID.cs LadybugTools_Engine/Compute/SimulationId.cs renamed to LadybugTools_Engine/Compute/SimulationID.cs

@@ -23,15 +23,24 @@
 using BH.Engine.Adapter;
 using BH.Engine.LadybugTools;
 using BH.oM.Adapter;
+using BH.oM.Base.Attributes;
 using BH.oM.LadybugTools;
 using System;
 using System.Collections.Generic;
+using System.ComponentModel;
 using System.Text;
 
 namespace BH.Engine.LadyBugTools
 {
     public static partial class Create
     {
+        [Description("Create an ExternalComfort object from an epw file, a simulation identifier, two materials and a typology (without a SimulationResult).")]
+        [Input("epwFile", "The epw file that the created SimulationResult is based on.")]
+        [Input("identifier", "The unique identifier for the created SimulationResult.")]
+        [Input("groundMaterial", "The material to use for the ground in the simulation.")]
+        [Input("shadeMaterial", "The material to use for the shade in the simulation.")]
+        [Input("typology", "The typology to use.")]
+        [Output("externalComfort", "The unpopulated external comfort.")]
         public static ExternalComfort ExternalComfort(FileSettings epwFile, string identifier, IEnergyMaterialOpaque groundMaterial, IEnergyMaterialOpaque shadeMaterial, Typology typology)
         {
             return new ExternalComfort()
@@ -41,6 +50,10 @@ public static ExternalComfort ExternalComfort(FileSettings epwFile, string ident
             };
         }
 
+        [Description("Create an ExternalComfort object from an existing SimulationResult and a Typology.")]
+        [Input("simulationResult", "The existing simulation result to use for this external comfort.")]
+        [Input("typology", "The typology to use.")]
+        [Output("externalComfort", "The unpopulated external comfort.")]
         public static ExternalComfort ExternalComfort(SimulationResult simulationResult, Typology typology)
         {
             return new ExternalComfort()

LadybugTools_Engine/Create/ExternalComfort.cs

@@ -21,15 +21,23 @@
  */
 
 using BH.oM.Adapter;
+using BH.oM.Base.Attributes;
 using BH.oM.LadybugTools;
 using System;
 using System.Collections.Generic;
+using System.ComponentModel;
 using System.Text;
 
 namespace BH.Engine.LadyBugTools
 {
     public static partial class Create
     {
+        [Description("Create an unpopulated SimulationResult from an epw file, identifier and two materials.")]
+        [Input("epwFile", "The epw file that the created SimulationResult is based on.")]
+        [Input("identifier", "The unique identifier for the created SimulationResult.")]
+        [Input("groundMaterial", "The material to use for the ground in the simulation.")]
+        [Input("shadeMaterial", "The material to use for the shade in the simulation.")]
+        [Output("simulationResult", "The unpopulated SimulationResult.")]
         public static SimulationResult SimulationResult(FileSettings epwFile, string identifier, IEnergyMaterialOpaque groundMaterial, IEnergyMaterialOpaque shadeMaterial)
         {
             return new SimulationResult()

LadybugTools_Engine/Create/SimulationResult.cs

@@ -40,6 +40,11 @@
 def walkability_heatmap(input_json: str, save_path: str, epw_file:str = None) -> str:
     try:
         style = os.environ.get("BHOM_style_context", "python_toolkit.bhom")
+
+        if not input_json.startswith("{"): #assume it's a path
+            with open(input_json, "r") as f:
+                input_json = f.read()
+
         argsDict = json.loads(input_json)
 
         ec = ExternalComfort.from_dict(json.loads(argsDict["external_comfort"]))

LadybugTools_Engine/Python/src/ladybugtools_toolkit/bhom/wrapped/plot/walkability_heatmap.py

@@ -22,6 +22,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.ComponentModel;
 using System.IO;
 using System.Reflection;
 using System.Text;
@@ -30,6 +31,7 @@ namespace BH.Engine.LadybugTools
 {
     public static partial class Query
     {
+        [Description("Gets the custom code folder for this toolkit if it exists, otherwise gets the default BHoM/Extensions/PythonCode folder.")]
         public static string PythonCodeDirectory()
         {
             string directory = Path.Combine(Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location), "PythonCode");

LadybugTools_Engine/Query/PythonCodeDirectory.cs

@@ -33,27 +33,27 @@ public class SolarRadiationData: ISimulationData
     {
         [DisplayText("Maximum Value")]
         [Description("The maximum incoming solar radiation.")]
-        public double MaxValue { get; set; } = double.NaN;
+        public virtual double MaxValue { get; set; } = double.NaN;
 
         [DisplayText("Minimum Value")]
         [Description("The minimum incoming solar radiation.")]
-        public double MinValue { get; set; } = double.NaN;
+        public virtual double MinValue { get; set; } = double.NaN;
 
         [DisplayText("Maximum Direction")]
         [Description("The direction, in degrees(°) clockwise from north that the maximum incoming solar radiation is coming from.")]
-        public double MaxDirection { get; set; } = double.NaN;
+        public virtual double MaxDirection { get; set; } = double.NaN;
 
         [DisplayText("Minimum Direction")]
         [Description("The direction, in degrees(°) clockwise from north that the minimum incoming solar radiation is coming from.")]
-        public double MinDirection { get; set; } = double.NaN;
+        public virtual double MinDirection { get; set; } = double.NaN;
 
         [DisplayText("Maximum Tilt")]
         [Description("The angle, in degrees(°) above the horizon that the maximum incoming solar radiation is coming from.")]
-        public double MaxTilt { get; set; } = double.NaN;
+        public virtual double MaxTilt { get; set; } = double.NaN;
 
         [DisplayText("Minimum Tilt")]
         [Description("The angle, in degrees(°) above the horizon that the minimum incoming solar radiation is coming from.")]
-        public double MinTilt { get; set;} = double.NaN;
+        public virtual double MinTilt { get; set;} = double.NaN;
     }
 }