Skip to content

Issues with pulling from links fixed#1486

Merged
pawelbaran merged 6 commits into
developfrom
Revit_Toolkit-#1477-PullFromMultipleLinksBug
Jun 13, 2024
Merged

Issues with pulling from links fixed#1486
pawelbaran merged 6 commits into
developfrom
Revit_Toolkit-#1477-PullFromMultipleLinksBug

Conversation

@pawelbaran

@pawelbaran pawelbaran commented Jun 12, 2024

Copy link
Copy Markdown
Member

Issues addressed by this PR

Closes #1477

Test files

This is quite a substantial change to the adapter mechanics, so thorough testing is required. Following tests to be done:

Changelog

Additional comments

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Jun 12, 2024
@pawelbaran pawelbaran self-assigned this Jun 12, 2024
@pawelbaran

Copy link
Copy Markdown
Member Author

@BHoMBot check versioning

@bhombot-ci

bhombot-ci Bot commented Jun 12, 2024

Copy link
Copy Markdown

@pawelbaran to confirm, the following actions are now queued:

  • check versioning

There are 19 requests in the queue ahead of you.

@enarhi enarhi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elements pulled from the linked models seem off per the PR Test Script, as the nested Link 1 Elements cause errors and some do not come through. Other than that this looks good for both of my test cases, with pull by element id also working nicely.

Pulling from Link 1:
image
image

@pawelbaran

Copy link
Copy Markdown
Member Author

Apologies @enarhi, I forgot to mention that the mirrored links require BHoM/BHoM_Engine#3356 to be built locally - updated the PR description now. Meanwhile, I think we can tell the tests went positive on your end, the only issue originating from the missing information about the need to build a specific BHoM_Engine branch. Thanks!

@pawelbaran

Copy link
Copy Markdown
Member Author

@BHoMBot check versioning

@bhombot-ci

bhombot-ci Bot commented Jun 13, 2024

Copy link
Copy Markdown

@pawelbaran to confirm, the following actions are now queued:

  • check versioning

There are 38 requests in the queue ahead of you.

@pawelbaran

Copy link
Copy Markdown
Member Author

@BHoMBot check required

@bhombot-ci

bhombot-ci Bot commented Jun 13, 2024

Copy link
Copy Markdown

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 50 requests in the queue ahead of you.

@bhombot-ci

bhombot-ci Bot commented Jun 13, 2024

Copy link
Copy Markdown

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@michal-pekacki michal-pekacki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passed, happy to approve 👍

@pawelbaran

Copy link
Copy Markdown
Member Author

@BHoMBot check installer

@bhombot-ci

bhombot-ci Bot commented Jun 13, 2024

Copy link
Copy Markdown

@pawelbaran to confirm, the following actions are now queued:

  • check installer

@pawelbaran

Copy link
Copy Markdown
Member Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance

@bhombot-ci

bhombot-ci Bot commented Jun 13, 2024

Copy link
Copy Markdown

@pawelbaran to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance

There are 1 requests in the queue ahead of you.

@pawelbaran

Copy link
Copy Markdown
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci

bhombot-ci Bot commented Jun 13, 2024

Copy link
Copy Markdown

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

@pawelbaran pawelbaran merged commit 4f273f5 into develop Jun 13, 2024
@pawelbaran pawelbaran deleted the Revit_Toolkit-#1477-PullFromMultipleLinksBug branch June 13, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Error or unexpected behaviour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues with pulling from links in case of one document being linked multiple times

3 participants