Push of pad foundation

[WojciechBuda00]

NOTE: Depends on

Issues addressed by this PR

Closes #1650

Test files

installer

Changelog

Additional comments

[WojciechBuda00]

@BHoMBot check installer

[bhombot-ci]

@WojciechBuda00 to confirm, the following actions are now queued:

• check installer

There are 2 requests in the queue ahead of you.

[WojciechBuda00]

@BHoMBot check installer

[bhombot-ci]

@WojciechBuda00 to confirm, the following actions are now queued:

• check installer

There are 12 requests in the queue ahead of you.

[WojciechBuda00]

@BHoMBot check project-compliance
@BHoMBot check code-compliance

[bhombot-ci]

@WojciechBuda00 to confirm, the following actions are now queued:

• check project-compliance
• check code-compliance

[bhombot-ci]

Please be advised that the check with reference 69798898856 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 49 additional annotations waiting, made up of 49 errors and 0 warnings.

[bhombot-ci]

Please be advised that the check with reference 69807979654 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 4 additional annotations waiting, made up of 4 errors and 0 warnings.

[WojciechBuda00]

@BHoMBot check installer

[bhombot-ci]

@WojciechBuda00 to confirm, the following actions are now queued:

• check installer

[pawelbaran]

There is still quite some work to do, see my comments. On top of that, I've tested the PR using the foundations pulled from #1646, and have a few comments comments:

• one element comes out rotated by 90 degrees
• foundations with nonlinear edges throw nasty errors on push
  
• have not tested, but what will happen with foundations with outlines as non-rectangular polylines?

We also need to catch up on 2 more topics:

• setting up the families
• update of foundation dimensions on Update

[bhombot-ci]

Please be advised that the check with reference 72981031267 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 99 additional annotations waiting, made up of 99 errors and 0 warnings.

[pawelbaran]

Looks quite good now, please see the code comments + there are compliance issues to fix as well.

[pawelbaran]

The code stopped compiling after the last commit

[pawelbaran]

Starts looking very good overall!! I left a few comments in the code, also one issue with the tests:

1. Select the upper left rectangle

2. Update polygon outline

3. Rhino vs Revit (mirror against Y):

[pawelbaran]

@BHoMBot check compliance

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

There are 347 requests in the queue ahead of you.

[pawelbaran]

Code reviewed & tested, really happy with it now, thank you @WojciechBuda00 💪

[pawelbaran]

@BHoMBot check required

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

There are 370 requests in the queue ahead of you.

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

@WojciechBuda00 just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_Engine