Skip to content

Commit bcd229d

Browse files
committed
Change strategy for reviewers to instead rely on codeowners
1 parent b468bb5 commit bcd229d

2 files changed

Lines changed: 10 additions & 37 deletions

File tree

.github/CODEOWNERS

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
# Global code owners for all files in this repository
2+
# These users will be automatically requested for review on all PRs
3+
4+
* @IsakNaslundBH @pawelbaran @adecler @michaelhoehn
5+
6+
# Specific patterns can be added here if needed
7+
# For example:
8+
# /docs/ @IsakNaslundBH @pawelbaran @adecler @michaelhoehn
9+
# *.yml @IsakNaslundBH @pawelbaran @adecler @michaelhoehn

.github/workflows/generation.yml

Lines changed: 1 addition & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -314,44 +314,8 @@ jobs:
314314
Write-Host "✓ Comment added to existing PR"
315315
} else {
316316
Write-Host "Creating pull request..."
317-
# First create the PR without reviewers
318-
$prUrl = gh pr create --title "API Updates" --body "Automated API documentation updates generated by APIGenerator workflow on $(Get-Date -Format 'yyyy-MM-dd HH:mm:ss')" --head $branch_name --base main
317+
gh pr create --title "API Updates" --body "Automated API documentation updates generated by APIGenerator workflow on $(Get-Date -Format 'yyyy-MM-dd HH:mm:ss')" --head $branch_name --base main
319318
Write-Host "✓ Pull request created successfully"
320-
321-
# Then try to add reviewers individually
322-
$reviewers = @("IsakNaslundBH", "pawelbaran", "adecler", "michaelhoehn")
323-
$successfulReviewers = @()
324-
$failedReviewers = @()
325-
326-
foreach ($reviewer in $reviewers) {
327-
Write-Host "Attempting to add reviewer: $reviewer"
328-
try {
329-
$output = gh pr edit $prUrl --add-reviewer $reviewer 2>&1 | Out-String
330-
Write-Host "Command output: $output"
331-
332-
# Verify the reviewer was actually added by checking the PR
333-
$prDetails = gh pr view $prUrl --json reviewRequests | ConvertFrom-Json
334-
$currentReviewers = $prDetails.reviewRequests | ForEach-Object { $_.login }
335-
336-
if ($currentReviewers -contains $reviewer) {
337-
$successfulReviewers += $reviewer
338-
Write-Host "✓ Successfully added reviewer: $reviewer"
339-
} else {
340-
$failedReviewers += $reviewer
341-
Write-Host "⚠️ Failed to add reviewer: $reviewer (not found in PR reviewers list)"
342-
}
343-
} catch {
344-
$failedReviewers += $reviewer
345-
Write-Host "⚠️ Failed to add reviewer: $reviewer (exception: $($_.Exception.Message))"
346-
}
347-
}
348-
349-
if ($successfulReviewers.Count -gt 0) {
350-
Write-Host "✓ Successfully added $($successfulReviewers.Count) reviewer(s): $($successfulReviewers -join ', ')"
351-
}
352-
if ($failedReviewers.Count -gt 0) {
353-
Write-Host "⚠️ Failed to add $($failedReviewers.Count) reviewer(s): $($failedReviewers -join ', ')"
354-
}
355319
}
356320
} else {
357321
Write-Host "No changes to commit"

0 commit comments

Comments
 (0)