Skip to content

Missing field on schema list #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BLMgithub merged 2 commits into from
Feb 24, 2026
Merged

Missing field on schema list #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a814a76
fix: add missing field to schema freeze list
BLMgithub Feb 24, 2026
23afb81
test: update suite for schema change
BLMgithub Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions data_pipeline/stages/assemble_validated_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ def merge_data(tables: dict) -> pd.DataFrame:
df_payments, on="order_id", how="left"
)

df_merged = df_merged.rename(columns={"payment_value": "order_revenue"})

if len(df_merged) != len(df_orders):
raise RuntimeError("Cardinality violation detected: expected 1 row per order")

Expand Down Expand Up @@ -136,6 +138,7 @@ def freeze_schema(df: pd.DataFrame) -> pd.DataFrame:

ENFORCED_SCHEMA = [
"order_id",
"order_revenue",
"seller_id",
"product_id",
"order_status",
Expand All @@ -153,6 +156,7 @@ def freeze_schema(df: pd.DataFrame) -> pd.DataFrame:

ENFORCED_DTYPES = {
"order_id": "string",
"order_revenue": "float64",
"seller_id": "string",
"product_id": "string",
"order_status": "string",
Expand Down
2 changes: 2 additions & 0 deletions tests/stages/test_assemble_validated_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ def valid_derived_df():
dtype="string",
),
"seller_id": pd.Series(["seller1", "seller2"], dtype="string"),
"order_revenue": pd.Series([12.34, 56.78], dtype="float64"),
"product_id": pd.Series(["prod1", "prod2"], dtype="string"),
"order_status": pd.Series(["delivered", "cancelled"], dtype="string"),
"order_purchase_timestamp": pd.Series(
Expand Down Expand Up @@ -243,6 +244,7 @@ def test_freeze_schema_enforces_strict_schema_success(valid_derived_df):

expected_dtypes = {
"order_id": "string",
"order_revenue": "float64",
"seller_id": "string",
"product_id": "string",
"order_status": "string",
Expand Down