[IA-5072] n+1 queries on Form submissions#3034
Open
Crebert08 wants to merge 12 commits into
Open
Conversation
hugo093
requested changes
May 19, 2026
Contributor
hugo093
left a comment
There was a problem hiding this comment.
good job , the query count drop is quite impressive.
However, some changes are needed imho: coding and "structural"
quang-le
requested changes
May 19, 2026
hugo093
requested changes
May 21, 2026
Contributor
hugo093
left a comment
There was a problem hiding this comment.
few code changes, for cleanliness :) otherwise lgtm
beygorghor
reviewed
May 21, 2026
hugo093
approved these changes
May 21, 2026
Contributor
hugo093
left a comment
There was a problem hiding this comment.
for my part and the comments I had, LGTM. I'll let the others review :) Thanks for the changes
beygorghor
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What problem is this PR solving?
This PR is about fixing the n+1 issues on the map tab on the form submissions list
Related JIRA tickets
IA-5072
Changes
Map tab
/home/crebert/Desktop/iaso/iaso/api/instances/views.py/home/crebert/Desktop/iaso/hat/assets/js/apps/Iaso/domains/instances/types/instance.ts/home/crebert/Desktop/iaso/hat/assets/js/apps/Iaso/domains/instances/requests.tsList Tab
/home/crebert/Desktop/iaso/iaso/api/instances/views.py/home/crebert/Desktop/iaso/iaso/models/instances.py/home/crebert/Desktop/iaso/iaso/tests/api/instances/test_instances.pyHow to test
Explain how to test your PR.
//
Print screen / video
Map tab
The queries go from this:

To this:

List tab
The queries go from this:

To this:

Notes
Things that the reviewers should know:
Doc
Tell us where the doc can be found (docs folder, wiki, in the code...).