[IA-5112] fix: don't display bypass nodes if the user can't take action#3044
Open
hugo093 wants to merge 1 commit into
Open
[IA-5112] fix: don't display bypass nodes if the user can't take action#3044hugo093 wants to merge 1 commit into
hugo093 wants to merge 1 commit into
Conversation
hugo093
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem is this PR solving?
In the validation workflow timeline, bypass validation nodes were displayed even though the user can't take any action.
Related JIRA tickets
IA-5112
Changes
How to test
Create a validation workflow with some bypass nodes and required roles
Trigger that workflow for an instance
User with the roles should see the bypass nodes
User without the roles should not see them
Notes
Will write fe tests once orval is implemented, will be easier with msw