feat: minor minor improvements

Author: mrivar

openhexa/sdk/pipelines/parameter/choices.py

@@ -26,7 +26,7 @@ class ChoicesFromFile(AstConstructible):
     def __init__(self, path: str, column: str | None = None):
         self.path = path
         self.column = column
-        self.validate_spec()
+        self._validate_spec()
         self.format = self._detect_format(path)
 
     @staticmethod
@@ -39,7 +39,7 @@ def _detect_format(path: str) -> str:
             )
         return "yaml" if ext == "yml" else ext
 
-    def validate_spec(self):
+    def _validate_spec(self):
         """Validate the path and column specification."""
         if not self.path or not isinstance(self.path, str):
             raise InvalidParameterError("ChoicesFromFile path must be a non-empty string.")

openhexa/sdk/pipelines/parameter/decorator.py

@@ -277,7 +277,7 @@ def parameter(
         An optional default value for the parameter (should be of the type defined by the type parameter)
     required : bool, default=True
         Whether the parameter is mandatory
-    multiple : bool, default=True
+    multiple : bool, default=False
         Whether this parameter should be provided multiple values (if True, the value must be provided as a list of
         values of the chosen type)
     directory : str, optional

tests/test_choices.py

@@ -67,10 +67,7 @@ class TestStringShorthand:
 
     def test_string_shorthand_csv(self):
         p = Parameter(code="district", type=str, choices="districts.csv")
-        assert isinstance(p.choices, ChoicesFromFile)
-        assert p.choices.path == "districts.csv"
-        assert p.choices.format == "csv"
-        assert p.choices.column is None
+        assert p.choices == ChoicesFromFile("districts.csv")
 
     def test_string_shorthand_json(self):
         p = Parameter(code="district", type=str, choices="data/regions.json")
@@ -104,7 +101,7 @@ def test_static_list_unaffected(self):
 
     def test_explicit_choices_from_file_unaffected(self):
         p = Parameter(code="district", type=str, choices=ChoicesFromFile("districts.csv", column="code"))
-        assert p.choices.column == "code"
+        assert p.choices == ChoicesFromFile("districts.csv", column="code")
 
     # --- invalid strings raise clearly ---
 
@@ -124,7 +121,7 @@ def test_empty_string_raises(self):
 
     def test_shorthand_has_no_column(self):
         p = Parameter(code="district", type=str, choices="districts.csv")
-        assert p.choices.column is None
+        assert p.choices == ChoicesFromFile("districts.csv")
 
     def test_decorator_with_string_shorthand(self):
         @parameter(code="district", type=str, choices="districts.csv")