move check to param init

Author: mrivar

openhexa/sdk/pipelines/parameter/decorator.py

@@ -94,6 +94,10 @@ def __init__(
         self.connection = connection
         self.directory = directory
         self.disables = list(disables) if disables else None
+        if self.disables and not isinstance(self.type, Boolean):
+            raise InvalidParameterError(
+                f"Only boolean parameters can use 'disables'. Parameter '{self.code}' is of type {self.type}."
+            )
 
         self._validate_default(default, multiple)
         self.default = default
@@ -215,10 +219,6 @@ def validate_parameters(parameters: list[Parameter]):
     for parameter in parameters:
         if not parameter.disables:
             continue
-        if not isinstance(parameter.type, Boolean):
-            raise InvalidParameterError(
-                f"Only boolean parameters can use 'disables'. Parameter '{parameter.code}' is of type {parameter.type}."
-            )
         for target_code in parameter.disables:
             if target_code == parameter.code:
                 raise InvalidParameterError(f"Parameter '{parameter.code}' cannot disable itself.")

tests/test_parameter.py

@@ -443,12 +443,10 @@ def test_validate_parameters_disables_ok():
     validate_parameters([controller, data_input])
 
 
-def test_validate_parameters_disables_must_be_boolean():
-    """Only boolean parameters can use 'disables'."""
-    controller = Parameter("mode", type=str, disables=["data_input"])
-    data_input = Parameter("data_input", type=str)
+def test_disables_must_be_boolean():
+    """Only boolean parameters can use 'disables' — rejected at construction time."""
     with pytest.raises(InvalidParameterError):
-        validate_parameters([controller, data_input])
+        Parameter("mode", type=str, disables=["data_input"])
 
 
 def test_validate_parameters_disables_unknown_target():