Don't allow restore if services are running

Author: bramj

README.md

@@ -301,7 +301,7 @@ Once configured, the following commands are available:
 | --- | --- |
 | `/usr/share/openhexa/openhexa.sh backup` | Back up the PostgreSQL cluster, workspace files, Forgejo data and `.env` snapshot. |
 | `/usr/share/openhexa/openhexa.sh backup-status` | Show the duplicity `collection-status` for both the `workspaces` and `forgejo` backends. |
-| `/usr/share/openhexa/openhexa.sh restore` | Restore the latest backup. We advise stopping the service before a full restore. |
+| `/usr/share/openhexa/openhexa.sh restore` | Restore the latest backup. This requires stopping the services before a full restore. |
 
 After a restore, an `openhexa-env.bak` file is left next to the workspace data:
 compare it with the live `.env` to make sure `ENCRYPTION_KEY`, `SECRET_KEY` and

script/openhexa.sh

@@ -266,10 +266,21 @@ function perform_restore() {
   require_backup_config || return 1
   (
     load_env
-    local location passphrase dumpfile_path envcopy_path pgpassfile psql_exit_code psql_result
+    local location passphrase dumpfile_path envcopy_path pgpassfile psql_exit_code psql_result running_services
     location=$(get_backup_config LOCATION)
     passphrase=$(get_backup_config PASSPHRASE)
 
+    echo -n "Check that no OpenHEXA services are running ... "
+    running_services=$(number_of_running_services)
+    if ((running_services > 0)); then
+      echo "KO"
+      echo "Refusing to restore while ${running_services} service(s) are running."
+      echo "Active connections would block DROP DATABASE during the dump replay."
+      echo "Stop everything first with: ./script/openhexa.sh stop"
+      return 1
+    fi
+    echo "OK"
+
     echo -n "Keep a copy of the workspace target ... "
     mv "${WORKSPACE_STORAGE_LOCATION}" "${WORKSPACE_STORAGE_LOCATION}-$(date -Iseconds)"
     mkdir "${WORKSPACE_STORAGE_LOCATION}"