Java: add foldInit to FoldVisitor#570
Open
zafer-esen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FoldVisitorfolds over the AST usingleaf(arg)(as base value) andcombine. This works well, but sometimes accessing the node itself is useful, this is currently not possible without overriding every singlevisitmethod.This PR adds
foldInit(Object p, A arg), defaulting toleaf(arg). Visit methods now useR r = foldInit(p, arg)instead ofR r = leaf(arg). Existing subclasses are unaffected.foldInittakesObjectbecause AST classes don't share a common base type (a common base type would also be useful, for instance to easily access line numbers, although I am not sure how that would be best implemented).(This change extends the fold from a catamorphism to a paramorphism.)
For example, counting AST nodes of a specific type using the proposed extension:
Without
foldInit, this requires overridingvisitfor every AST class, becauseleafonly receivesarg, not the nodep.Includes a doctest and a changelog entry.