Skip to content

Commit 46c38c3

Browse files
kevinccbsgclaude
andcommitted
ci: install pinned Chrome for twd-cli via web-checkout pattern
Pin puppeteer@24.43.1 (Chrome 148, what twd-cli's ^24.43.0 resolves to) and pass --ignore-scripts so puppeteer's postinstall can't leave a partial Chrome folder. Clear the cache first for good measure. Same pattern as web-checkout's daily-green workflow. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent b71fb2a commit 46c38c3

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

.github/workflows/ci.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,15 @@ jobs:
3838
# The shared action installs Chrome via puppeteer@latest, which can
3939
# drift from twd-cli's pinned puppeteer (e.g. puppeteer 25 installs
4040
# Chrome 149 while twd-cli needs 148).
41-
# puppeteer's postinstall (run while npx prepares the twd-cli env)
42-
# leaves a partial Chrome folder that makes the install fail, so
43-
# clear the cache right before installing.
41+
# Install the Chrome version twd-cli's puppeteer (^24.43.0) expects.
42+
# Pin the puppeteer version explicitly: the shared action installs via
43+
# puppeteer@latest, which drifts to a different Chrome on new majors.
44+
# --ignore-scripts skips puppeteer's postinstall, which leaves partial
45+
# Chrome folders in CI. Same pattern as web-checkout's workflow.
4446
- name: Install Chrome for twd-cli
45-
run: npx -y -p twd-cli -c 'rm -rf ~/.cache/puppeteer && puppeteer browsers install chrome'
47+
run: |
48+
rm -rf ~/.cache/puppeteer
49+
npx -y --ignore-scripts puppeteer@24.43.1 browsers install chrome
4650
4751
- name: Run TWD tests
4852
uses: BRIKEV/twd-cli/.github/actions/run@main

0 commit comments

Comments
 (0)