Skip to content

Fix dash to dot issue in samplesheets when parsing usernames from project IDs#396

Open
ESapenaVentura wants to merge 5 commits intoBU-ISCIII:developfrom
ESapenaVentura:esv-fix-dot-dash-issue
Open

Fix dash to dot issue in samplesheets when parsing usernames from project IDs#396
ESapenaVentura wants to merge 5 commits intoBU-ISCIII:developfrom
ESapenaVentura:esv-fix-dot-dash-issue

Conversation

@ESapenaVentura
Copy link
Copy Markdown
Member

Changes

  • Modified samplesheet.py to add logic to check all possible combinations of a username with dashes instead of dots (e.g. "as-it.wa-s" would be checked for as.it.wa-s, as-it.wa.s, as.it.wa.s). When checking, original will always be preferred (Will be checked earlier)

Possible future issues

  • If there are multiple "unique" names with combination of dashes and dots (e.g. users "a.sv" and "a-sv"), this will cause issues.
  • Project IDs are kept with dashes (e.g. MiSeq_i100_GEN_003_20260319_enrique-sapena)
  • Stored samplesheets also keep dashes in the project IDs

saramonzon
saramonzon previously approved these changes Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants