Skip to content

Upload pipeline-manager samples to iSkyLIMS#882

Open
Aberdur wants to merge 5 commits into
BU-ISCIII:developfrom
Aberdur:codex/pipeline-manager-iskylims-upload
Open

Upload pipeline-manager samples to iSkyLIMS#882
Aberdur wants to merge 5 commits into
BU-ISCIII:developfrom
Aberdur:codex/pipeline-manager-iskylims-upload

Conversation

@Aberdur
Copy link
Copy Markdown
Contributor

@Aberdur Aberdur commented May 6, 2026

PR Description

  • Upload pipeline-manager sample metadata to both relecov-platform and iSkyLIMS.
  • Ensure relecov-platform runs first so unique_sample_id is available before the iSkyLIMS upload.
  • Use unique_sample_id as the iSkyLIMS sample_name fallback to avoid creating duplicate samples with local sequencing IDs.
  • Make --skip_db_upload skip the database upload step as expected.
  • Add clearer upload messages for relecov-platform and iSkyLIMS.

PR Checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (black and flake8).
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@Aberdur Aberdur self-assigned this May 6, 2026
Comment thread relecov_tools/pipeline_manager.py Outdated
platforms.append(configured_platform)

platforms = list(dict.fromkeys(platforms))
if "relecov" in platforms:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this?

Comment thread relecov_tools/pipeline_manager.py Outdated
return platforms

@staticmethod
def _get_platform_display_name(platform: str) -> str:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this maybe could be in the config?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants