Added support for configurable enum sources, template-only fields, and AMR metadata JSON generation.#883
Merged
Merged
Conversation
Daniel-VM
reviewed
May 21, 2026
Daniel-VM
left a comment
Member
There was a problem hiding this comment.
Looks good!
However, since this is specific to AMR genes only, unless I’m wrong, I’ll move this implementation to the schema utils: https://github.com/BU-ISCIII/relecov-tools/tree/develop/relecov_tools/assets/schema_utils
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates schema generation to support configurable enum sources from the input Excel, template-only lab form fields, alphabetically sorted enum values, and automatic generation of
amr_genes.jsonfor downstream AMR metadata processing.Changes
ONLYinsubmitting_lab_formto include fields in the metadata template while excluding them from the generated JSON schema..txtfiles inconfor from Excel sheets using@sheet:sheet_name:column_name.@sheet:sheet_name:column_name:filter_column=filter_value.amr_acquired_genesto derive its enum values fromamr_gene_listusing the configurable Excel enum source syntax.amr_genes.jsonin the schema output directory usingamr_gene_list.Not applicable,Not collected,Not provided,Missing,Restricted access, andOtherat the end.PR Checklist
black and flake8).CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).