Feedback by github-classroom[bot] · Pull Request #1 · BUMETCS673/CS673OLSum25Team2

github-classroom · 2025-05-12T14:47:38Z

👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to the default branch since the assignment started. Your teacher can see this too.

Notes for teachers

Use this PR to leave feedback. Here are some tips:

Click the Files changed tab to see all of the changes pushed to the default branch since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.
Click the Commits tab to see the commits pushed to the default branch. Click a commit to see specific changes.
If you turned on autograding, then click the Checks tab to see the results.
This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below.
For more information about this pull request, read “Leaving assignment feedback in GitHub”.

Subscribed: @arqii22 @Taniatos @hongjie94 @t1homas @ghoveybu @schin8

netlify · 2025-05-26T22:27:22Z

✅ Deploy Preview for mymagicalbedtime ready!

Name	Link
🔨 Latest commit	`dca9e60`
🔍 Latest deploy log	https://app.netlify.com/projects/mymagicalbedtime/deploys/6851923c12254b0008e3fdfd
😎 Deploy Preview	https://deploy-preview-1--mymagicalbedtime.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2025-05-27T01:34:57Z

✅ Deploy Preview for velvety-entremet-8ac832 canceled.

Name	Link
🔨 Latest commit	`dca9e60`
🔍 Latest deploy log	https://app.netlify.com/projects/velvety-entremet-8ac832/deploys/6851923cb142a20008f7c46b

update README

fix server setting

Fixed some UI responsiveness issues

Pipeline improvements

github-actions · 2025-06-15T20:55:55Z

File	Coverage
All files	`8%`	❌
controllers/settingController.js	`0%`	❌
controllers/storyController.js	`0%`	❌
controllers/userController.js	`66%`	❌
models/GenerationRequestModel.js	`0%`	❌
models/ParentalControlsModel.js	`85%`	✅
models/StoryModel.js	`0%`	❌
models/UserModel.js	`19%`	❌
routes/setting.js	`0%`	❌
routes/story.js	`0%`	❌

Minimum allowed coverage is 75%

Generated by 🐒 cobertura-action against dca9e60

+          let cleanedResponse = storyResponse
+            .replace(/\n/g, "\\n")
+            .replace(/\r/g, "\\r")
+            .replace(/\t/g, "\\t")
+            .replace(/\f/g, "\\f")
+            .replace(/\b/g, "\\b")
+            .replace(/\\/g, "\\\\")


To fix the issue, we need to ensure that the storyResponse string is sanitized without introducing double-escaping. The best approach is to use a well-tested library for JSON parsing and sanitization, such as json5 or safe-json-stringify, which can handle edge cases more robustly. Alternatively, we can simplify the cleaning process by removing redundant replacements and focusing on extracting valid JSON directly.

The fix involves:

Removing the problematic replace chain starting on line 71.

Using a more robust method to extract and parse JSON from storyResponse, ensuring that escaping is handled correctly.

Adding comments to clarify the sanitization process and prevent future errors.

+  const startTime = Date.now();
+  const { imageDescription, storyId } = req.body;
+  const userId = req.user._id;
+  console.log(imageDescription, storyId);


To fix the issue, we will sanitize the untrusted input (imageDescription) before passing it to console.log. Specifically, we will use a format string with a %s specifier to ensure that the untrusted input is treated as a string, regardless of its content. This approach aligns with the recommendation provided in the background section.

The changes will be made to line 235 in the generateImage function. We will replace the current console.log statement with one that uses a format string and passes imageDescription as an argument.

+      revisedPrompt: imageResult.revisedPrompt,
+    };
+
+    await Story.findByIdAndUpdate(storyId, updates);


To fix the issue, we need to ensure that the storyId value is validated before it is used in the findByIdAndUpdate query. Since MongoDB _id fields are typically ObjectIds, we can validate that storyId is a valid ObjectId. If it is not, we should return an error response to the user.

The best way to implement this fix is to use the mongoose.Types.ObjectId.isValid method, which checks whether a given value is a valid ObjectId. This ensures that only valid ObjectIds are passed to the query, mitigating the risk of NoSQL injection.

+      audioUrl: audioDownloadUrl,
+    };
+
+    await Story.findByIdAndUpdate(storyId, updates);


To fix the issue, we need to ensure that the storyId value is properly validated before being used in the Story.findByIdAndUpdate query. The best approach is to check that storyId is a valid MongoDB ObjectId. This can be achieved using the mongoose.Types.ObjectId.isValid method, which ensures that the input is a valid ObjectId format.

Steps to implement the fix:

Add a validation step for storyId using mongoose.Types.ObjectId.isValid.

If storyId is invalid, return an appropriate error response to the user.

Proceed with the database query only if storyId passes validation.

+      return (
+        text
+          // Remove or replace problematic punctuation
+          .replace(/'/g, "'") // Replace curly quotes with straight quotes


To fix the issue, the replacement operation should be updated to replace curly single quotes (‘ and ’) with straight single quotes ('). This aligns with the apparent intent of the function to normalize text for audio generation. The corrected line will use a regular expression that matches both types of curly single quotes and replaces them with a straight single quote.

+        text
+          // Remove or replace problematic punctuation
+          .replace(/'/g, "'") // Replace curly quotes with straight quotes
+          .replace(/"/g, '"') // Replace curly quotes with straight quotes


To fix the issue, the .replace(/"/g, '"') operation should be updated to correctly normalize curly quotes (“ and ”) to straight quotes ("). This can be achieved by using a regular expression that matches curly quotes and replacing them with straight quotes. Specifically, the replacement string should be updated to '"', and the regular expression should be modified to match curly quotes.

The fix involves editing the cleanTextForAudio function in the code/backend/services/openaiService.js file. No new dependencies are required for this fix.

+          .replace(/[""]/g, '"') // Normalize quotation marks
+
+          // Add pauses for better speech flow
+          .replace(/\. /g, ". ") // Ensure space after periods


To fix the issue, the redundant replacement operation on line 148 should be removed. The replacement of . with itself does not serve any purpose and can be safely eliminated without affecting the functionality of the cleanTextForAudio function. This will simplify the code and improve readability.

+
+          // Add pauses for better speech flow
+          .replace(/\. /g, ". ") // Ensure space after periods
+          .replace(/\? /g, "? ") // Ensure space after question marks


To fix the issue, the redundant replacement operation /\? /g should be removed from the cleanTextForAudio function. This will eliminate unnecessary code and ensure that the function only performs meaningful transformations on the input text. No additional imports, methods, or definitions are required for this fix.

+          // Add pauses for better speech flow
+          .replace(/\. /g, ". ") // Ensure space after periods
+          .replace(/\? /g, "? ") // Ensure space after question marks
+          .replace(/! /g, "! ") // Ensure space after exclamation marks


To fix the issue, the redundant replacement operation on line 150 should be removed. This will eliminate the unnecessary code and ensure that the cleanTextForAudio function only performs meaningful transformations on the input text. No additional imports, methods, or definitions are required for this fix.

ghoveybu temporarily deployed to my-magical-bedtime May 26, 2025 16:03 Inactive

ghoveybu temporarily deployed to my-magical-bedtime May 26, 2025 22:15 Inactive

ghoveybu temporarily deployed to my-magical-bedtime May 26, 2025 22:27 Inactive

ghoveybu temporarily deployed to my-magical-bedtime May 26, 2025 22:29 Inactive

ghoveybu temporarily deployed to my-magical-bedtime May 27, 2025 00:07 Inactive

ghoveybu temporarily deployed to my-magical-bedtime May 27, 2025 01:34 Inactive

hongjie94 had a problem deploying to magicalbedtimebackend May 27, 2025 01:35 Failure

ghoveybu temporarily deployed to my-magical-bedtime May 27, 2025 04:21 Inactive

hongjie94 had a problem deploying to magicalbedtimebackend May 27, 2025 04:22 Failure

Taniatos added 19 commits May 27, 2025 13:35

Update Navbar.css

7ae7221

Update Navbar.css

ddadc54

Update Navbar.jsx

ad566e1

Update Navbar.jsx

c0669cc

Added images for character selection

42d1de2

Added images for character selection

ba1e83d

Delete StoryCustomizationInterface. css

4c0d8a8

Delete StoryCustomizationInterface. css

c931bc1

Update StoryCustomizationInterface.jsx

1d68c54

Update StoryCustomizationInterface.jsx

1fae4a8

Update StoryCustomizationInterface.css

bf0ee9f

Update StoryCustomizationInterface.css

eacb84e

Create CharacterCarousel.jsx

da4134c

Create CharacterCarousel.jsx

1101073

Create CharacterCarousel.css

c6370e6

Create CharacterCarousel.css

518fafd

Update Home.jsx

71a83fa

Update Home.jsx

b5b7612

Update App.jsx

64d53a7

hongjie94 and others added 21 commits June 13, 2025 17:32

Delete .gitignore 2

eadd2ad

update README

3874a5f

Merge pull request #95 from BUMETCS673/zack_env

85c8558

update README

fixed dockerfile

e69d5db

trying to fix jest still

9118925

Jest again, works on my machine

56afe5c

fix server setting

18e755b

trying to fix coverage

0344fb9

Merge pull request #96 from BUMETCS673/zack_env

28c9049

fix server setting

copy coverage out of container

a628a3a

fixing syntax

09179aa

added step to remove old coverage report

75c2cbd

changing permissions to allow copying

419da16

using cache

0a51ee4

removing jest check from Dockerfile

56d538b

Update LoginRequired.css

729f8b2

Update About.css

04c80e2

Update About.jsx

90d8066

Update MyStory.css

06e120f

Merge pull request #98 from BUMETCS673/frontend_UI

5167971

Fixed some UI responsiveness issues

Merge pull request #97 from BUMETCS673/pipeline_improvements

38cb39d

Pipeline improvements

github-advanced-security AI found potential problems Jun 15, 2025

View reviewed changes

hongjie94 and others added 7 commits June 15, 2025 18:31

fix footer

3af2121

Iteration 3 Group Submission

21903fb

Update Readme.md

6da51d2

Update Readme.md

9e98d0f

Update Readme.md

fddcfea

Update Readme.md

fee4db4

Update Readme.md

dca9e60

@@ -70,16 +70,8 @@
                       // Clean the JSON string before parsing
-                      let cleanedResponse = storyResponse
-                        .replace(/\n/g, "\\n")
-                        .replace(/\r/g, "\\r")
-                        .replace(/\t/g, "\\t")
-                        .replace(/\f/g, "\\f")
-                        .replace(/\b/g, "\\b")
-                        .replace(/\\/g, "\\\\")
-                        .replace(/"/g, '\\"');
+                      // Attempt to extract JSON directly from the response
+                      const jsonMatch = storyResponse.match(/\{[\s\S]*\}/);
+                      let cleanedResponse = jsonMatch ? jsonMatch[0] : storyResponse;
-                      // Alternative approach: try to extract JSON from the response
-                      const jsonMatch = cleanedResponse.match(/\{[\s\S]*\}/);
-                      if (jsonMatch) {
-                        cleanedResponse = jsonMatch[0];
-                      }
+                      // Log the extracted JSON for debugging
+                      console.log("Extracted JSON response:", cleanedResponse);

@@ -1 +1,2 @@
+            const mongoose = require("mongoose");
             const Story = require("../models/StoryModel");
@@ -233,2 +234,10 @@
               const { imageDescription, storyId } = req.body;
+              // Validate storyId
+              if (!mongoose.Types.ObjectId.isValid(storyId)) {
+                return res.status(400).json({
+                  success: false,
+                  error: "Invalid storyId",
+                });
+              }
               const userId = req.user._id;

@@ -1,2 +1,3 @@
             const Story = require("../models/StoryModel");
+            const mongoose = require("mongoose");
             const parentalControls = require("../models/ParentalControlsModel");
@@ -298,2 +299,10 @@
+              // Validate storyId
+              if (!mongoose.Types.ObjectId.isValid(storyId)) {
+                return res.status(400).json({
+                  success: false,
+                  error: "Invalid storyId format",
+                });
+              }
               const userId = req.user._id;

@@ -142,3 +142,3 @@
                       .replace(/'/g, "'") // Replace curly quotes with straight quotes
-                      .replace(/"/g, '"') // Replace curly quotes with straight quotes
+                      .replace(/[“”]/g, '"') // Replace curly quotes with straight quotes
                       .replace(/['']/g, "'") // Normalize apostrophes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feedback#1

Feedback#1
github-classroom[bot] wants to merge 388 commits into
feedbackfrom
main

github-classroom Bot commented May 12, 2025 •

edited

Loading

Uh oh!

netlify Bot commented May 26, 2025 •

edited

Loading

Uh oh!

netlify Bot commented May 27, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 15, 2025 •

edited

Loading

Uh oh!

Uh oh!

Check failure

Copilot Autofix

Check failure

Copilot Autofix

Check failure

Copilot Autofix

Check failure

Copilot Autofix

Check warning

Copilot Autofix

Check warning

Copilot Autofix

Check warning

Copilot Autofix

Check warning

Copilot Autofix

Check warning

Copilot Autofix

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

github-classroom Bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for mymagicalbedtime ready!

Uh oh!

netlify Bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for velvety-entremet-8ac832 canceled.

Uh oh!

github-actions Bot commented Jun 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Check failure

Uh oh!

Copilot Autofix

Check failure

Uh oh!

Copilot Autofix

Check failure

Uh oh!

Copilot Autofix

Check failure

Uh oh!

Copilot Autofix

Check warning

Copilot Autofix

Check warning

Copilot Autofix

Check warning

Copilot Autofix

Check warning

Copilot Autofix

Check warning

Copilot Autofix

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-classroom Bot commented May 12, 2025 •

edited

Loading

netlify Bot commented May 26, 2025 •

edited

Loading

netlify Bot commented May 27, 2025 •

edited

Loading

github-actions Bot commented Jun 15, 2025 •

edited

Loading