Fix Blob::offset allowing one-past-the-end indices#7125
Open
Chessing234 wants to merge 1 commit into
Open
Conversation
CHECK_LE(n, num()) permitted n == num(), which computes an offset past the last element. Use CHECK_LT to match the vector overload. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blob::offset(n, c, h, w)usedCHECK_LE(n, num()), which allowsn == num(). For a batch of 10,offset(10)passes the check but points one element past the buffer end.Valid indices are
[0, dim), which is what the vector overload already enforces withCHECK_LT. This change makes the legacy 4D accessor consistent.Fixes #3420
Made with Cursor