Prevent recursion in the connection repository by only trying to re-fetch the token once after an implicit reauthentication

Author: mbabker

src/Authentication/StorageBackedConnectionRepository.php

@@ -86,7 +86,7 @@ public function findTokenForConnection(Connection $connection): TokenInterface
             // Generally this would mean the token expired from storage, attempt to re-authenticate the connection
             $this->authenticator->authenticate($connection);
 
-            return $this->findTokenForConnection($connection);
+            return $this->tokenStorage->getToken($storageId);
         }
     }
 

tests/Authentication/StorageBackedConnectionRepositoryTest.php

@@ -66,7 +66,7 @@ public function testFindTokenForConnectionAfterReauthenticating(): void
         /** @var MockObject&TokenInterface $token */
         $token = $this->createMock(TokenInterface::class);
 
-        $this->tokenStorage->expects(self::exactly(2))
+        $this->tokenStorage->expects(self::once())
             ->method('generateStorageId')
             ->with($connection)
             ->willReturn((string) $storageId);