TC39 class-fields: convert type-only override fields to declare (TC39 define semantics)

Flipping to TC39 decorators forces `useDefineForClassFields: true`. Under define
semantics, an uninitialized narrowing `override` field emits a class-field
definition that runs after `super()` and resets the value the base constructor
assigned (e.g. FreeCamera/FlyCamera `movement`, and other narrowing overrides),
clobbering inherited state and breaking ~96 unit tests.

All 134 conversions in this commit are type-only override fields (no initializer):
`override` emitted nothing under the old compiler, and `declare` emits nothing
under the new one, so each change is provably behavior-identical while removing
the clobbering field definition. A blanket conversion is more consistent and
robust than a narrow decorated-hierarchy analysis.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Author: RaananW

packages/dev/core/src/Actions/condition.pure.ts

@@ -116,7 +116,7 @@ export class ValueCondition extends Condition {
      * Internal only The action manager for the condition
      * @internal
      */
-    public override _actionManager: ActionManager;
+    declare public _actionManager: ActionManager;
 
     private _target: any;
     private _effectiveTarget: any;
@@ -218,7 +218,7 @@ export class PredicateCondition extends Condition {
      * Internal only - manager for action
      * @internal
      */
-    public override _actionManager: ActionManager;
+    declare public _actionManager: ActionManager;
 
     /**
      * Creates a new PredicateCondition
@@ -249,7 +249,7 @@ export class StateCondition extends Condition {
      * Internal only - manager for action
      * @internal
      */
-    public override _actionManager: ActionManager;
+    declare public _actionManager: ActionManager;
 
     private _target: any;
 

packages/dev/core/src/AudioV2/abstractAudio/staticSound.ts

@@ -103,7 +103,7 @@ export interface IStaticSoundCloneOptions {
  * Static sounds are created by the {@link CreateSoundAsync} function.
  */
 export abstract class StaticSound extends AbstractSound {
-    protected override _instances: Set<_StaticSoundInstance>;
+    declare protected _instances: Set<_StaticSoundInstance>;
     protected abstract override readonly _options: IStaticSoundStoredOptions;
 
     /**

packages/dev/core/src/AudioV2/webAudio/subNodes/spatialWebAudioSubNode.ts

@@ -40,7 +40,7 @@ export class _SpatialWebAudioSubNode extends _SpatialAudioSubNode {
     private _positionZ: _WebAudioParameterComponent;
 
     /** @internal */
-    public override readonly engine: _WebAudioEngine;
+    declare public readonly engine: _WebAudioEngine;
 
     /** @internal */
     public readonly orientation: Vector3 = _SpatialAudioDefaults.orientation.clone();

packages/dev/core/src/AudioV2/webAudio/subNodes/stereoWebAudioSubNode.ts

@@ -14,7 +14,7 @@ export class _StereoWebAudioSubNode extends _StereoAudioSubNode {
     private _pan: _WebAudioParameterComponent;
 
     /** @internal */
-    public override readonly engine: _WebAudioEngine;
+    declare public readonly engine: _WebAudioEngine;
 
     /** @internal */
     public readonly node: StereoPannerNode;

packages/dev/core/src/AudioV2/webAudio/subNodes/volumeWebAudioSubNode.ts

@@ -16,7 +16,7 @@ export class _VolumeWebAudioSubNode extends _VolumeAudioSubNode implements IWebA
     private _volume: _WebAudioParameterComponent;
 
     /** @internal */
-    public override readonly engine: _WebAudioEngine;
+    declare public readonly engine: _WebAudioEngine;
 
     /** @internal */
     public readonly node: AudioNode;

packages/dev/core/src/AudioV2/webAudio/webAudioBus.ts

@@ -15,7 +15,7 @@ export class _WebAudioBus extends AudioBus implements IWebAudioSuperNode {
     protected _subGraph: _WebAudioBusAndSoundSubGraph;
 
     /** @internal */
-    public override readonly engine: _WebAudioEngine;
+    declare public readonly engine: _WebAudioEngine;
 
     /** @internal */
     public constructor(name: string, engine: _WebAudioEngine, options: Partial<IAudioBusOptions>) {
@@ -104,7 +104,7 @@ export class _WebAudioBus extends AudioBus implements IWebAudioSuperNode {
     }
 
     private static _SubGraph = class extends _WebAudioBusAndSoundSubGraph {
-        protected override _owner: _WebAudioBus;
+        declare protected _owner: _WebAudioBus;
 
         protected get _downstreamNodes(): Nullable<Set<AbstractAudioNode>> {
             return this._owner._downstreamNodes ?? null;

packages/dev/core/src/AudioV2/webAudio/webAudioMainBus.ts

@@ -10,7 +10,7 @@ export class _WebAudioMainBus extends MainAudioBus implements IWebAudioSuperNode
     protected _subGraph: _WebAudioBaseSubGraph;
 
     /** @internal */
-    public override readonly engine: _WebAudioEngine;
+    declare public readonly engine: _WebAudioEngine;
 
     /** @internal */
     public constructor(name: string, engine: _WebAudioEngine) {
@@ -83,7 +83,7 @@ export class _WebAudioMainBus extends MainAudioBus implements IWebAudioSuperNode
     }
 
     private static _SubGraph = class extends _WebAudioBaseSubGraph {
-        protected override _owner: _WebAudioMainBus;
+        declare protected _owner: _WebAudioMainBus;
 
         protected get _downstreamNodes(): Nullable<Set<AbstractAudioNode>> {
             return this._owner._downstreamNodes ?? null;

packages/dev/core/src/AudioV2/webAudio/webAudioMainOut.ts

@@ -11,7 +11,7 @@ export class _WebAudioMainOut extends _MainAudioOut implements IWebAudioInNode {
     private _volume: _WebAudioParameterComponent;
 
     /** @internal */
-    public override readonly engine: _WebAudioEngine;
+    declare public readonly engine: _WebAudioEngine;
 
     /** @internal */
     public constructor(engine: _WebAudioEngine) {

packages/dev/core/src/AudioV2/webAudio/webAudioSoundSource.ts

@@ -19,7 +19,7 @@ export class _WebAudioSoundSource extends AbstractSoundSource {
     public _audioContext: AudioContext | OfflineAudioContext;
 
     /** @internal */
-    public override readonly engine: _WebAudioEngine;
+    declare public readonly engine: _WebAudioEngine;
 
     /** @internal */
     public constructor(name: string, webAudioNode: AudioNode, engine: _WebAudioEngine, options: Partial<ISoundSourceOptions>) {
@@ -125,7 +125,7 @@ export class _WebAudioSoundSource extends AbstractSoundSource {
     }
 
     private static _SubGraph = class extends _WebAudioBusAndSoundSubGraph {
-        protected override _owner: _WebAudioSoundSource;
+        declare protected _owner: _WebAudioSoundSource;
 
         protected get _downstreamNodes(): Nullable<Set<AbstractAudioNode>> {
             return this._owner._downstreamNodes ?? null;

packages/dev/core/src/AudioV2/webAudio/webAudioStaticSound.ts

@@ -27,14 +27,14 @@ export class _WebAudioStaticSound extends StaticSound implements IWebAudioSuperN
     private _buffer: _WebAudioStaticSoundBuffer;
     private _stereo: Nullable<_StereoAudio> = null;
 
-    protected override readonly _options: IStaticSoundStoredOptions;
+    declare protected readonly _options: IStaticSoundStoredOptions;
     protected _subGraph: _WebAudioBusAndSoundSubGraph;
 
     /** @internal */
     public _audioContext: AudioContext | OfflineAudioContext;
 
     /** @internal */
-    public override readonly engine: _WebAudioEngine;
+    declare public readonly engine: _WebAudioEngine;
 
     /** @internal */
     public constructor(name: string, engine: _WebAudioEngine, options: Partial<IStaticSoundOptions>) {
@@ -172,7 +172,7 @@ export class _WebAudioStaticSound extends StaticSound implements IWebAudioSuperN
     }
 
     private static _SubGraph = class extends _WebAudioBusAndSoundSubGraph {
-        protected override _owner: _WebAudioStaticSound;
+        declare protected _owner: _WebAudioStaticSound;
 
         protected get _downstreamNodes(): Nullable<Set<AbstractAudioNode>> {
             return this._owner._downstreamNodes ?? null;
@@ -190,7 +190,7 @@ export class _WebAudioStaticSoundBuffer extends StaticSoundBuffer {
     public _audioBuffer: AudioBuffer;
 
     /** @internal */
-    public override readonly engine: _WebAudioEngine;
+    declare public readonly engine: _WebAudioEngine;
 
     /** @internal */
     public constructor(engine: _WebAudioEngine) {
@@ -295,11 +295,11 @@ class _WebAudioStaticSoundInstance extends _StaticSoundInstance implements IWebA
     private _sourceNode: Nullable<AudioBufferSourceNode> = null;
     private _volumeNode: GainNode;
 
-    protected override readonly _options: IStaticSoundInstanceOptions;
-    protected override _sound: _WebAudioStaticSound;
+    declare protected readonly _options: IStaticSoundInstanceOptions;
+    declare protected _sound: _WebAudioStaticSound;
 
     /** @internal */
-    public override readonly engine: _WebAudioEngine;
+    declare public readonly engine: _WebAudioEngine;
 
     public constructor(sound: _WebAudioStaticSound, options: IStaticSoundInstanceOptions) {
         super(sound);