test: add TC39 decorator tests and fix tsconfig.test.json lib

Author: RaananW

packages/dev/core/test/unit/Decorators/decorators.inline-test.ts

@@ -0,0 +1,68 @@
+/**
+ * Quick inline test to verify TC39 decorators work correctly.
+ * Run with: npx ts-node --esm --project tsconfig.test.json packages/dev/core/test/unit/Decorators/decorators.inline-test.ts
+ */
+
+// Test 1: Symbol.metadata polyfill
+(Symbol as any).metadata ??= Symbol.for("Symbol.metadata");
+
+// Test 2: A simple TC39 class field decorator
+function trackField(displayName: string) {
+    return function <This, V>(_value: undefined, context: ClassFieldDecoratorContext<This, V>) {
+        const key = `__tracked_${String(context.name)}`;
+        if (!Object.hasOwn(context.metadata, key)) {
+            (context.metadata as any)[key] = displayName;
+        }
+    };
+}
+
+// Test 3: A TC39 accessor decorator (like expandToProperty)
+function doubleAccessor<This, V extends number>(
+    _value: ClassAccessorDecoratorTarget<This, V>,
+    _context: ClassAccessorDecoratorContext<This, V>
+): ClassAccessorDecoratorResult<This, V> {
+    return {
+        get(this: This): V {
+            return (_value.get.call(this) * 2) as V;
+        },
+        set(this: This, value: V) {
+            _value.set.call(this, value);
+        },
+    };
+}
+
+class TestClass {
+    @trackField("My Number")
+    myNum: number = 42;
+
+    @doubleAccessor
+    accessor doubled: number = 5;
+}
+
+// Verify metadata
+const metadata = (TestClass as any)[Symbol.metadata];
+console.assert(metadata !== undefined, "Symbol.metadata should be set on class");
+console.assert((metadata as any).__tracked_myNum === "My Number", "Field decorator should store metadata");
+
+// Verify accessor
+const instance = new TestClass();
+console.assert(instance.doubled === 10, `Accessor should return doubled value, got ${instance.doubled}`);
+instance.doubled = 7;
+console.assert(instance.doubled === 14, `After setting 7, accessor should return 14, got ${instance.doubled}`);
+
+// Test 4: Inheritance
+class ChildClass extends TestClass {
+    @trackField("Child Prop")
+    childProp: string = "hello";
+}
+
+const childMeta = (ChildClass as any)[Symbol.metadata];
+console.assert(childMeta !== undefined, "Child should have metadata");
+console.assert((childMeta as any).__tracked_childProp === "Child Prop", "Child metadata should have its own properties");
+
+// Walk the prototype chain
+const parentMeta = Object.getPrototypeOf(childMeta);
+console.assert(parentMeta !== null, "Child metadata prototype should be parent metadata");
+console.assert((parentMeta as any).__tracked_myNum === "My Number", "Parent metadata should be accessible via prototype chain");
+
+console.log("All decorator tests passed!");

packages/dev/core/test/unit/Decorators/decorators.test.ts

@@ -0,0 +1,79 @@
+/**
+ * Quick sanity test for TC39 decorator migration.
+ * Tests the core decorator functions work correctly with Symbol.metadata.
+ */
+import { serialize, serializeAsColor3, expandToProperty } from "core/Misc/decorators";
+import { GetDirectStore, GetMergedStore } from "core/Misc/decorators.functions";
+import { Color3 } from "core/Maths/math.color";
+
+describe("TC39 Decorator Migration", () => {
+    describe("serialize decorator", () => {
+        it("should store serialization metadata via Symbol.metadata", () => {
+            class TestClass {
+                @serialize()
+                public myProp: number = 42;
+
+                @serialize("renamedProp")
+                public anotherProp: string = "hello";
+            }
+
+            const store = GetDirectStore(new TestClass());
+            expect(store).toBeDefined();
+            expect(store["myProp"]).toBeDefined();
+            expect(store["myProp"].type).toBe(0); // default type
+            expect(store["renamedProp"]).toBeDefined();
+        });
+
+        it("should merge stores from parent and child classes", () => {
+            class Parent {
+                @serialize()
+                public parentProp: number = 1;
+            }
+
+            class Child extends Parent {
+                @serialize()
+                public childProp: number = 2;
+            }
+
+            const child = new Child();
+            const merged = GetMergedStore(child);
+            expect(merged["parentProp"]).toBeDefined();
+            expect(merged["childProp"]).toBeDefined();
+        });
+    });
+
+    describe("serializeAsColor3 decorator", () => {
+        it("should serialize color3 properties", () => {
+            class ColorClass {
+                @serializeAsColor3()
+                public color: Color3 = new Color3(1, 0, 0);
+            }
+
+            const store = GetDirectStore(new ColorClass());
+            expect(store["color"]).toBeDefined();
+        });
+    });
+
+    describe("expandToProperty decorator", () => {
+        it("should create getter/setter that reads from backing field", () => {
+            class ExpandClass {
+                // @ts-expect-error Accessed dynamically by expandToProperty decorator
+                private _myCallback() {
+                    // no-op 
+                }
+
+                @expandToProperty("_myCallback")
+                public accessor myExpanded: number;
+
+                // @ts-expect-error Backing field accessed dynamically by expandToProperty
+                private _myExpanded: number = 10;
+            }
+
+            const instance = new ExpandClass();
+            expect(instance.myExpanded).toBe(10);
+
+            instance.myExpanded = 20;
+            expect(instance.myExpanded).toBe(20);
+        });
+    });
+});

packages/dev/smartFilters/test/unit/customShaderBlock.test.ts

@@ -4,7 +4,7 @@ import { SmartFilter } from "../../src/smartFilter.js";
 import { ImportCustomBlockDefinition } from "../../src/serialization/importCustomBlockDefinition.js";
 import { CustomShaderBlock } from "../../src/blockFoundation/customShaderBlock.js";
 import { SerializedShaderBlockDefinitionV1 } from "../../src/serialization/v1/shaderBlockSerialization.types";
-import { IPropertyDescriptionForEdition, PropertyTypeForEdition, getSmartFilterEditableProperties } from "../../src/editorUtils/editableInPropertyPage.js";
+import { PropertyTypeForEdition, getSmartFilterEditableProperties } from "../../src/editorUtils/editableInPropertyPage.js";
 
 const glslValidFloatDefaultValue = `
 // { "smartFilterBlockType": "TestBlock", "namespace": "Bug.Repro" }

tsconfig.test.json

@@ -15,7 +15,9 @@
             "es2017",
             "es2022.error",
             "es2022.array",
-            "es2021.string"
+            "es2021.string",
+            "esnext.decorators",
+            "es2022.object"
         ]
     }
 }