fix: update shader file handling and improve webcam source options retrieval

Author: RaananW

packages/dev/core/test/unit/Decorators/decorators.test.ts

@@ -59,7 +59,7 @@ describe("TC39 Decorator Migration", () => {
             class ExpandClass {
                 // @ts-expect-error Accessed dynamically by expandToProperty decorator
                 private _myCallback() {
-                    // no-op 
+                    // no-op
                 }
 
                 @expandToProperty("_myCallback")

packages/dev/smartFilters/src/utils/buildTools/convertShaders.ts

@@ -14,34 +14,26 @@ import { log, error } from "./buildToolsLogger.js";
 export function ConvertShaders(shaderPath: string, smartFiltersCorePath: string, babylonCorePath?: string) {
     const stats = fs.statSync(shaderPath);
 
-    let shaderFiles: fs.Dirent[];
+    let shaderFiles: { name: string; dir: string }[];
 
     if (stats.isFile()) {
-        // If it's a file, create a Dirent-like object for consistency
-        const fileName = path.basename(shaderPath);
-        const dirPath = path.dirname(shaderPath);
-        shaderFiles = [
-            {
-                name: fileName,
-                path: dirPath,
-                isFile: () => true,
-                isDirectory: () => false,
-            } as fs.Dirent,
-        ];
+        shaderFiles = [{ name: path.basename(shaderPath), dir: path.dirname(shaderPath) }];
     } else if (stats.isDirectory()) {
         // Get all files in the directory
         const allFiles = fs.readdirSync(shaderPath, { withFileTypes: true, recursive: true });
 
         // Find all shaders (files with .fragment.glsl or .block.glsl extensions)
-        shaderFiles = allFiles.filter((file) => file.isFile() && (file.name.endsWith(".fragment.glsl") || file.name.endsWith(".block.glsl")));
+        shaderFiles = allFiles
+            .filter((file) => file.isFile() && (file.name.endsWith(".fragment.glsl") || file.name.endsWith(".block.glsl")))
+            .map((file) => ({ name: file.name, dir: file.parentPath }));
     } else {
         error(`Error: ${shaderPath} is neither a file nor a directory.`);
         return;
     }
 
     // Convert all shaders
     for (const shaderFile of shaderFiles) {
-        const fullPathAndFileName = path.join(shaderFile.path, shaderFile.name);
+        const fullPathAndFileName = path.join(shaderFile.dir, shaderFile.name);
         ConvertShader(fullPathAndFileName, smartFiltersCorePath, babylonCorePath);
     }
 }

packages/tools/guiEditor/src/components/propertyTab/propertyGrids/gui/gridPropertyGridComponent.tsx

@@ -158,7 +158,8 @@ export class GridPropertyGridComponent extends React.Component<IGridPropertyGrid
 
     parsePercentage(value: string) {
         let floatResult;
-        if (value.trim().at(-1) === "%") {
+        const trimmed = value.trim();
+        if (trimmed[trimmed.length - 1] === "%") {
             floatResult = parseFloat(value.replace("%", "")) / 100;
         } else {
             floatResult = parseFloat(value);

packages/tools/smartFiltersEditorControl/src/configuration/editorBlocks/webCamInputBlock/webCamInputBlock.ts

@@ -125,7 +125,9 @@ export class WebCamInputBlock extends InputBlock<ConnectionPointType.Texture> {
      */
     @editableInPropertyPage("Source", PropertyTypeForEdition.List, "PROPERTIES", {
         notifiers: { update: true },
-        options: WebCamInputBlock._WebCamSourceManager.onSourcesLoaded as Observable<IEditablePropertyListOption[]>,
+        get options() {
+            return WebCamInputBlock._WebCamSourceManager.onSourcesLoaded as Observable<IEditablePropertyListOption[]>;
+        },
         valuesAreStrings: true,
     })
     public set webcamSourceId(id: string) {