Restore AnimatorAvatar fixes from Claude#18248
Conversation
- Fix inverted toString separator logic in Animation (comma on first item instead of subsequent) - Fix missing .length in AnimationGroup.toString (printed array object instead of count) - Guard against division by zero in AnimatorAvatar proportionRatio calculation - Fix vertical axis auto-detection comparing only 2 of 3 axes in AnimatorAvatar - Throw Error instead of string literal in PathCursor.move - Remove dead duplicated RegisterTargetForLateAnimationBinding from animatable.core.ts - Change == to === in ElasticEase.easeInCore for strict equality consistency - Rename shadowed loop variable in AnimatorAvatar._fixAnimationGroup - Replace verbose manual iterator patterns with for-of loops in AnimatorAvatar - Add audit summary document Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The project's tsconfig does not enable --downlevelIteration, so for-of on Set<T> causes TS2802. Restored the original manual iterator pattern (.keys() / .next() / .done). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Switching back to for-of to identify which build command requires the manual iterator pattern. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The UMD build (packages/public/umd/babylonjs/tsconfig.build.json) targets ES5, which doesn't support for-of on Set without --downlevelIteration. The manual iterator pattern is required. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Documents that the verbose iterator pattern is required because the UMD build targets ES5 and for-of on Set needs --downlevelIteration. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…tion artifacts - Restore RegisterTargetForLateAnimationBinding as exported public API - Fix @internal JSDoc on ElasticEase.easeInCore (was accidentally removed) - Remove claude/ directory from tracked files - Remove all inline "Claude explanation" comments from production code Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Keep only the i→j rename for the inner loop variable that shadowed the outer loop's i. Revert the vertical axis auto-detection and division-by-zero guard changes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ename" This reverts commit 581ae46.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18248/merge/index.html#WGZLGJ#4600 Links to test your changes to core in the published versions of the Babylon tools (does not contain changes you made to the tools themselves): https://playground.babylonjs.com/?snapshot=refs/pull/18248/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/18248/merge#BCU1XR#0 If you made changes to the sandbox or playground in this PR, additional comments will be generated soon containing links to the dev versions of those tools. |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
4 participants
Please see @Popov72 's comment here: #18234 (comment)
I accidentally removed some of the fixes from Claude, and this PR looks to restore them. Thank you for your help!