Skip to content

Commit 35c50dd

Browse files
bkaradzic-microsoftbkaradzicCopilot
authored
Bump JsRuntimeHost pin (napi string-getter underflow fix + 3 others) (#1759)
## What Bump the `JsRuntimeHost` FetchContent pin to JRH `main` HEAD `272f6a9f`. This brings in a security fix in JsRuntimeHost — an integer underflow in the Chakra `napi_get_value_string_*` getters when a caller passes a non-null buffer with `bufsize == 0` (`bufsize - 1` underflows to `SIZE_MAX`, causing an out-of-bounds write): - BabylonJS/JsRuntimeHost#197 It is a single-commit fast-forward over the pin currently on `master` (`99457c03`, JRH #181). ## Verification - CMake reconfigure fetches JsRuntimeHost at `272f6a9f`; the `#197` fix is present in `js_native_api_chakra.cc`. - Playground (D3D11, Debug) configures and builds clean against JsRuntimeHost `272f6a9f` (`napi`, `JsRuntime`, `AppRuntime`, and the polyfills relink; `Playground.exe` is produced). Co-authored-by: Branimir Karadzic <branimirkaradzic@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent fe380a7 commit 35c50dd

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ FetchContent_Declare(ios-cmake
5454
EXCLUDE_FROM_ALL)
5555
FetchContent_Declare(JsRuntimeHost
5656
GIT_REPOSITORY https://github.com/BabylonJS/JsRuntimeHost.git
57-
GIT_TAG 99457c03625782c3eeac6609f632538c7c9445d0)
57+
GIT_TAG 272f6a9f3de78f7c4cd8a838ae9655c81fc4881a)
5858
FetchContent_Declare(metal-cpp
5959
GIT_REPOSITORY https://github.com/bkaradzic/metal-cpp.git
6060
GIT_TAG metal-cpp_26

0 commit comments

Comments
 (0)