Commit 35c50dd
Bump JsRuntimeHost pin (napi string-getter underflow fix + 3 others) (#1759)
## What
Bump the `JsRuntimeHost` FetchContent pin to JRH `main` HEAD `272f6a9f`.
This brings in a security fix in JsRuntimeHost — an integer underflow in
the Chakra `napi_get_value_string_*` getters when a caller passes a
non-null buffer with `bufsize == 0` (`bufsize - 1` underflows to
`SIZE_MAX`, causing an out-of-bounds write):
- BabylonJS/JsRuntimeHost#197
It is a single-commit fast-forward over the pin currently on `master`
(`99457c03`, JRH #181).
## Verification
- CMake reconfigure fetches JsRuntimeHost at `272f6a9f`; the `#197` fix
is present in `js_native_api_chakra.cc`.
- Playground (D3D11, Debug) configures and builds clean against
JsRuntimeHost `272f6a9f` (`napi`, `JsRuntime`, `AppRuntime`, and the
polyfills relink; `Playground.exe` is produced).
Co-authored-by: Branimir Karadzic <branimirkaradzic@gmail.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent fe380a7 commit 35c50dd
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
| 57 | + | |
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| |||
0 commit comments