Skip to content

Commit 384a7c5

Browse files
Drop BN-rendered reference image re-bakes from #1647 triage
Reference images must come from Babylon.js, never from Babylon Native's own renderer (the renderer might be broken; re-baking from BN would mask real regressions). Restore upstream/master versions of: - Apps/Playground/ReferenceImages/apply-all-post-processes.png - Apps/Playground/ReferenceImages/bakedVertexAnimation.png Revert the two re-enables (idx 'Baked Vertex Animation' and 'apply-all-post-processes') in config.json. Both stay excluded with descriptive reason text naming the post-SPIRV-Cross-bump pixel-diff regression and explicitly noting that BN-side re-baking is not the fix per project policy. The three reason rewrites for Screen Space Reflections 2 / Sprites Pixel Perfect / soft-transparent-shadows (legitimately excluded BN rendering regressions) are kept from the original commit.
1 parent b094b58 commit 384a7c5

3 files changed

Lines changed: 4 additions & 0 deletions

File tree

3.42 KB
Loading
-19.2 KB
Loading

Apps/Playground/Scripts/config.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2297,6 +2297,8 @@
22972297
{
22982298
"title": "Baked Vertex Animation",
22992299
"playgroundId": "#14WJWW#13",
2300+
"excludeFromAutomaticTesting": true,
2301+
"reason": "Pixel-diff against Babylon.js reference after SPIRV-Cross bump (#1695): animation timing renders one frame off. Cannot re-bake from BN renderer per project policy.",
23002302
"referenceImage": "bakedVertexAnimation.png"
23012303
},
23022304
{
@@ -2778,6 +2780,8 @@
27782780
"title": "apply-all-post-processes",
27792781
"playgroundId": "#MJ59Y8#18",
27802782
"renderCount": 10,
2783+
"excludeFromAutomaticTesting": true,
2784+
"reason": "Pixel-diff against Babylon.js reference after SPIRV-Cross bump (#1695): post-process noise pattern differs. Cannot re-bake from BN renderer per project policy.",
27812785
"referenceImage": "apply-all-post-processes.png"
27822786
},
27832787
{

0 commit comments

Comments
 (0)