Skip to content

Commit 5a404d7

Browse files
bghgaryCopilot
andauthored
Bump Babylon.js from 9.0.0 to 9.3.4 (#1667)
## Summary Bump Babylon.js from `9.0.0` to `9.3.4` across all `package.json` / `package-lock.json` files under `Apps/`. ## Motivation Recent CI runs (e.g. on #1666) show `Win32_x64_D3D11` intermittently failing on the `Light Projection Texture` UnitTests case: ``` [Log] Running Light Projection Texture [Log] First pixel off at 182856: Value: (51, 51, 53) - Expected: (46, 22, 16) [Log] Pixel difference: 170840 pixels. [Log] failed ##[error]Process completed with exit code -1. ``` Two upstream readiness bugs combine to produce this flake, and both need to land to remove it: - **BabylonJS/Babylon.js#18255** — "Fix material readiness to gate on light texture readiness." Shipped in Babylon.js 9.3.2. - **BabylonJS/Babylon.js#18355** — heightmap `CreateGroundFromHeightMap` readiness (the async image load was not gated by `addPendingData`/`removePendingData`, so `scene.isReady()` could return true before the heightmap was uploaded). Shipped in Babylon.js 9.3.4. Earlier 9.3.2 / 9.3.3 bumps on this branch picked up #18255 but the flake persisted because the heightmap race (#18355) was still present. Bumping to `^9.3.4` picks up both. ## Changes - `Apps/package.json` + lockfile: bump `babylonjs`, `babylonjs-gltf2interface`, `babylonjs-gui`, `babylonjs-loaders`, `babylonjs-materials`, `babylonjs-serializers` to `^9.3.4`. - `Apps/UnitTests/JavaScript/package.json`: bump `babylonjs`, `babylonjs-materials`, `@babylonjs/core`, `@babylonjs/materials` to `^9.3.4`. - `Apps/PrecompiledShaderTest/JavaScript/package.json` + lockfile: bump `@babylonjs/core` to `^9.3.4`. No code changes — dependency bump only. ## Verification CI on this PR is expected to go green on `Win32_x64_D3D11 Light Projection Texture` where it was previously flaky. Validated out-of-band on #1668 (monkey-patched 9.3.3 → 9.3.4 behavior) running LPT ×20 × 6 configs = 120/120 on Ubuntu_GCC_JSC. --- [Created by Copilot on behalf of @bghgary] --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent ff2e970 commit 5a404d7

5 files changed

Lines changed: 67 additions & 68 deletions

File tree

Apps/PrecompiledShaderTest/JavaScript/package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Apps/PrecompiledShaderTest/JavaScript/package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,17 @@
1111
"prepare:shaders": "tsx ./tools/prepareShaders.ts"
1212
},
1313
"license": "MIT",
14-
"dependencies": {},
1514
"devDependencies": {
1615
"@babel/cli": "^7.28.3",
1716
"@babel/core": "^7.28.3",
1817
"@babel/preset-env": "^7.28.3",
19-
"@babylonjs/core": "^9.0.0",
18+
"@babylonjs/core": "^9.3.4",
2019
"@types/node": "^24.7.1",
2120
"rimraf": "^6.0.1",
21+
"terser-webpack-plugin": "^5.3.10",
2222
"ts-loader": "^9.5.4",
2323
"tsx": "^4.20.6",
2424
"typescript": "^5.5.4",
25-
"terser-webpack-plugin": "^5.3.10",
2625
"webpack": "^5.101.3",
2726
"webpack-cli": "^6.0.1"
2827
},

Apps/UnitTests/JavaScript/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
"watch": "webpack -watch"
88
},
99
"dependencies": {
10-
"babylonjs": "^9.0.0",
11-
"babylonjs-materials": "^9.0.0",
10+
"babylonjs": "^9.3.4",
11+
"babylonjs-materials": "^9.3.4",
1212
"chai": "^5.2.0",
1313
"jsc-android": "^241213.1.0",
1414
"mocha": "^11.1.0",
@@ -27,8 +27,8 @@
2727
"@babel/preset-react": "^7.27.1",
2828
"@babel/preset-typescript": "^7.27.1",
2929
"@babel/runtime": "^7.28.2",
30-
"@babylonjs/core": "^9.0.0",
31-
"@babylonjs/materials": "^9.0.0",
30+
"@babylonjs/core": "^9.3.4",
31+
"@babylonjs/materials": "^9.3.4",
3232
"babel-loader": "^10.0.0",
3333
"buffer": "^6.0.3",
3434
"core-js": "^3.45.0",

Apps/package-lock.json

Lines changed: 51 additions & 51 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Apps/package.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@
99
"getNightly": "node scripts/getNightly.js"
1010
},
1111
"dependencies": {
12-
"babylonjs": "^9.0.0",
13-
"babylonjs-gltf2interface": "^9.0.0",
14-
"babylonjs-gui": "^9.0.0",
15-
"babylonjs-loaders": "^9.0.0",
16-
"babylonjs-materials": "^9.0.0",
17-
"babylonjs-serializers": "^9.0.0",
12+
"babylonjs": "^9.3.4",
13+
"babylonjs-gltf2interface": "^9.3.4",
14+
"babylonjs-gui": "^9.3.4",
15+
"babylonjs-loaders": "^9.3.4",
16+
"babylonjs-materials": "^9.3.4",
17+
"babylonjs-serializers": "^9.3.4",
1818
"jsc-android": "^241213.1.0",
1919
"v8-android": "^7.8.2"
2020
}

0 commit comments

Comments
 (0)