Skip to content

Commit 5ebfb00

Browse files
bkaradzic-microsoftBranimir KaradžićCopilot
authored
Fix Windows CI: pin to windows-2022 (VS2022 generator missing on new image) (#1742)
## Problem Every Windows/UWP job is failing at the configure step: ``` Image: windows-2025-vs2026 cmake -G "Visual Studio 17 2022" ... CMake Error at CMakeLists.txt:16 (project): Generator Visual Studio 17 2022 could not find any instance of Visual Studio. ``` GitHub repointed the `windows-latest` label to an image (`windows-2025-vs2026`) that ships **only Visual Studio 2026, no VS2022**. Our workflows configure with the hard-coded `Visual Studio 17 2022` CMake generator, so configuration fails before anything is built. `master` looks green only because its checks are cached from before the image change. ## Fix Pin the four Windows workflows to the `windows-2022` runner, which still provides the VS2022 toolset the generator targets: - `build-win32.yml` - `build-uwp.yml` - `build-win32-shader.yml` - `test-install-win32.yml` This is the minimal, decoupled fix: it restores green CI immediately and keeps the known-good toolchain. It also side-steps the unrelated MSVC **C4875** GSL deprecation that the VS2026 toolset surfaces (handled separately upstream in JsRuntimeHost). Migrating to the VS2026 generator can be done later as a deliberate follow-up once the toolchain churn settles. Co-authored-by: Branimir Karadžić <branimirk@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 6bb8014 commit 5ebfb00

5 files changed

Lines changed: 8 additions & 4 deletions

File tree

.github/workflows/build-uwp.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ on:
1313

1414
jobs:
1515
build:
16-
runs-on: windows-latest
16+
runs-on: windows-2022
1717
timeout-minutes: 30
1818
steps:
1919
- uses: actions/checkout@v5

.github/workflows/build-win32-shader.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ on:
1010

1111
jobs:
1212
build:
13-
runs-on: windows-latest
13+
runs-on: windows-2022
1414
timeout-minutes: 30
1515
steps:
1616
- uses: actions/checkout@v5

.github/workflows/build-win32.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ on:
2121

2222
jobs:
2323
build:
24-
runs-on: windows-latest
24+
runs-on: windows-2022
2525
timeout-minutes: 60
2626
steps:
2727
- uses: actions/checkout@v5

.github/workflows/test-install-win32.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ on:
55

66
jobs:
77
test-install:
8-
runs-on: windows-latest
8+
runs-on: windows-2022
99
timeout-minutes: 30
1010
steps:
1111
- uses: actions/checkout@v5

Apps/ModuleLoadTest/Source/App.Win32.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,10 @@ namespace ModuleLoadTest
129129
"dxil.dll",
130130
// VS Start-Without-Debugging launch environment
131131
"kernel.appcore.dll",
132+
// Ambient shell/appcore DLL pulled in transitively (e.g. via
133+
// windows.storage.dll / DComp) on some Windows images such as the
134+
// GitHub windows-2022 runner; not introduced by BabylonNative.
135+
"twinapi.appcore.dll",
132136
};
133137
for (const auto& prefix : kPrefixes)
134138
{

0 commit comments

Comments
 (0)