Commit 77c4f66
Add native cube render target support (re-enables 2 shadow-with-instances tests)
Render-to-cubemap on the native engine so ReflectionProbe and point-light
cube shadow maps render instead of dereferencing the null WebGL context.
- InitializeTexture: optional isCube param -> Texture::CreateCube.
- CreateFrameBuffer: optional layer param so the color attachment targets a
single cube face (bgfx::Attachment layer); the JS side creates one
framebuffer per face and binds the matching one per face.
Re-enables the "Shadows with instances in left/right handed system" validation
tests that previously crashed/hung.
Requires the paired Babylon.js change (native cube render target JS overrides);
CI stays red until a babylonjs npm with that change is published and the dep
bumped here.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent b6ecf80 commit 77c4f66
2 files changed
Lines changed: 13 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1825 | 1825 | | |
1826 | 1826 | | |
1827 | 1827 | | |
1828 | | - | |
1829 | | - | |
1830 | 1828 | | |
1831 | 1829 | | |
1832 | 1830 | | |
1833 | 1831 | | |
1834 | 1832 | | |
1835 | 1833 | | |
1836 | | - | |
1837 | | - | |
1838 | 1834 | | |
1839 | 1835 | | |
1840 | 1836 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1321 | 1321 | | |
1322 | 1322 | | |
1323 | 1323 | | |
| 1324 | + | |
1324 | 1325 | | |
1325 | 1326 | | |
1326 | 1327 | | |
| |||
1332 | 1333 | | |
1333 | 1334 | | |
1334 | 1335 | | |
1335 | | - | |
| 1336 | + | |
| 1337 | + | |
| 1338 | + | |
| 1339 | + | |
| 1340 | + | |
| 1341 | + | |
| 1342 | + | |
| 1343 | + | |
| 1344 | + | |
1336 | 1345 | | |
1337 | 1346 | | |
1338 | 1347 | | |
| |||
1820 | 1829 | | |
1821 | 1830 | | |
1822 | 1831 | | |
| 1832 | + | |
| 1833 | + | |
1823 | 1834 | | |
1824 | 1835 | | |
1825 | 1836 | | |
| |||
1830 | 1841 | | |
1831 | 1842 | | |
1832 | 1843 | | |
1833 | | - | |
| 1844 | + | |
1834 | 1845 | | |
1835 | 1846 | | |
1836 | 1847 | | |
| |||
0 commit comments