Commit 9d45e33
Use quick_exit in test UnhandledExceptionHandlers for consistency (#1640)
Replace `set_exception`-based error handling with `std::quick_exit(1)`
in unit test `UnhandledExceptionHandler`s to match the pattern used by
Playground and PrecompiledShaderTest.
**Why:** When an unhandled JS exception occurs, the JS thread continues
processing the work queue after the handler returns. Using
`set_exception` on a promise signals the waiting thread, but more queued
work can execute before the main thread reacts — causing cascading
errors and confusing logs. `quick_exit` stops everything immediately,
which is the right behavior for tests.
**Changes:**
- Replace `set_exception` with `std::quick_exit(1)` in Tests.JavaScript,
Tests.ShaderCache, and Tests.UniformPadding
- Keep `std::cerr` output before `quick_exit` so CI captures the error
message
- Move `std::promise` declarations closer to first use (no longer
captured by the handler)
- Remove redundant `.flush()` calls after `std::endl` (which already
guarantees a flush per the C++ spec)
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 6bde319 commit 9d45e33
File tree
3 files changed
+18
-19
lines changed- Apps/UnitTests/Source
3 files changed
+18
-19
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
| 15 | + | |
14 | 16 | | |
15 | 17 | | |
16 | 18 | | |
| |||
36 | 38 | | |
37 | 39 | | |
38 | 40 | | |
39 | | - | |
40 | | - | |
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
| 47 | + | |
48 | 48 | | |
49 | | - | |
50 | | - | |
51 | | - | |
| 49 | + | |
52 | 50 | | |
53 | 51 | | |
54 | 52 | | |
| |||
59 | 57 | | |
60 | 58 | | |
61 | 59 | | |
| 60 | + | |
| 61 | + | |
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
68 | | - | |
69 | 68 | | |
70 | 69 | | |
71 | 70 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
| |||
28 | 29 | | |
29 | 30 | | |
30 | 31 | | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | 32 | | |
35 | 33 | | |
36 | | - | |
| 34 | + | |
37 | 35 | | |
38 | | - | |
39 | | - | |
40 | | - | |
| 36 | + | |
41 | 37 | | |
42 | 38 | | |
43 | 39 | | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
50 | 49 | | |
51 | 50 | | |
52 | 51 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| |||
30 | 31 | | |
31 | 32 | | |
32 | 33 | | |
33 | | - | |
34 | | - | |
35 | 34 | | |
36 | | - | |
| 35 | + | |
37 | 36 | | |
38 | | - | |
| 37 | + | |
39 | 38 | | |
40 | 39 | | |
41 | 40 | | |
| |||
95 | 94 | | |
96 | 95 | | |
97 | 96 | | |
| 97 | + | |
| 98 | + | |
98 | 99 | | |
99 | 100 | | |
100 | 101 | | |
| |||
0 commit comments