Skip to content

Commit a5d50ae

Browse files
bghgaryCopilot
andauthored
Remove obsolete CMake setup action; use runner-preinstalled cmake (#1679)
## Context CI started failing today on every fresh runner with: ``` ##[error]Unable to find version matching 3.31.6 ``` from `jwlawson/actions-setup-cmake@v2`. The GitHub release for `v3.31.6` still exists, and so do `3.31.8` and `3.31.12`, but the action's resolver can't find any of them right now. Bumping the pin to other 3.31.x patches did not help. ## Why the pin existed The original Azure Pipelines `cmake.yml` script (pre-#1661) had this comment: > `# Force using older cmake See https://gitlab.kitware.com/cmake/cmake/-/issues/22021` That CMake bug — `MACOSX_PACKAGE_LOCATION` mishandling for `INTERFACE_SOURCES` — was [**fixed in CMake 3.22**](https://gitlab.kitware.com/cmake/cmake/-/merge_requests/6698) (MR!6698). The pin carried over into #1661 as part of the faithful Azure-→-Actions port. ## Why we don't need to pin anymore - `CMakeLists.txt` requires `cmake_minimum_required(VERSION 3.21)`. - All current GitHub-hosted runner images (Ubuntu, Windows, macOS) ship CMake ≥ 3.30. - The original `#22021` bug we were avoiding is fixed in 3.22, well below anything any runner ships today. ## Change Remove the `jwlawson/actions-setup-cmake@v2` step (and its `CMAKE_VERSION` env var) from all 11 workflow files. The runner-preinstalled CMake satisfies our minimum and avoids the broken action altogether. [Created by Copilot on behalf of @bghgary] --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 9851e93 commit a5d50ae

11 files changed

Lines changed: 0 additions & 71 deletions

.github/workflows/build-android.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ on:
1111
type: string
1212

1313
env:
14-
CMAKE_VERSION: '3.31.6'
1514
NDK_VERSION: '28.2.13676358'
1615

1716
jobs:
@@ -21,10 +20,6 @@ jobs:
2120
steps:
2221
- uses: actions/checkout@v5
2322

24-
- uses: jwlawson/actions-setup-cmake@v2
25-
with:
26-
cmake-version: ${{ env.CMAKE_VERSION }}
27-
2823

2924
- uses: actions/setup-java@v5
3025
with:

.github/workflows/build-ios.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,20 +15,13 @@ on:
1515
type: string
1616
default: macos-latest
1717

18-
env:
19-
CMAKE_VERSION: '3.31.6'
20-
2118
jobs:
2219
build:
2320
runs-on: ${{ inputs.runs-on }}
2421
timeout-minutes: 30
2522
steps:
2623
- uses: actions/checkout@v5
2724

28-
- uses: jwlawson/actions-setup-cmake@v2
29-
with:
30-
cmake-version: ${{ env.CMAKE_VERSION }}
31-
3225

3326
- name: Select Xcode ${{ inputs.xcode-version }}
3427
run: sudo xcode-select --switch /Applications/Xcode_${{ inputs.xcode-version }}.app/Contents/Developer

.github/workflows/build-linux.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ on:
1818
default: false
1919

2020
env:
21-
CMAKE_VERSION: '3.31.6'
2221
UBSAN_OPTIONS: halt_on_error=1:print_stacktrace=1:symbolize=1
2322
ASAN_OPTIONS: abort_on_error=1
2423

@@ -32,10 +31,6 @@ jobs:
3231
steps:
3332
- uses: actions/checkout@v5
3433

35-
- uses: jwlawson/actions-setup-cmake@v2
36-
with:
37-
cmake-version: ${{ env.CMAKE_VERSION }}
38-
3934

4035
- name: Install packages
4136
run: |

.github/workflows/build-macos.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ on:
2121
default: macos-latest
2222

2323
env:
24-
CMAKE_VERSION: '3.31.6'
2524
UBSAN_OPTIONS: halt_on_error=1:print_stacktrace=1:symbolize=1
2625
ASAN_OPTIONS: abort_on_error=1
2726

@@ -32,10 +31,6 @@ jobs:
3231
steps:
3332
- uses: actions/checkout@v5
3433

35-
- uses: jwlawson/actions-setup-cmake@v2
36-
with:
37-
cmake-version: ${{ env.CMAKE_VERSION }}
38-
3934

4035
- name: Select Xcode ${{ inputs.xcode-version }}
4136
run: sudo xcode-select --switch /Applications/Xcode_${{ inputs.xcode-version }}.app/Contents/Developer

.github/workflows/build-uwp.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,20 +11,13 @@ on:
1111
type: string
1212
default: direct
1313

14-
env:
15-
CMAKE_VERSION: '3.31.6'
16-
1714
jobs:
1815
build:
1916
runs-on: windows-latest
2017
timeout-minutes: 30
2118
steps:
2219
- uses: actions/checkout@v5
2320

24-
- uses: jwlawson/actions-setup-cmake@v2
25-
with:
26-
cmake-version: ${{ env.CMAKE_VERSION }}
27-
2821

2922
- name: Set NAPI variables
3023
id: napi

.github/workflows/build-win32-shader.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,20 +8,13 @@ on:
88
type: string
99
default: x64
1010

11-
env:
12-
CMAKE_VERSION: '3.31.6'
13-
1411
jobs:
1512
build:
1613
runs-on: windows-latest
1714
timeout-minutes: 30
1815
steps:
1916
- uses: actions/checkout@v5
2017

21-
- uses: jwlawson/actions-setup-cmake@v2
22-
with:
23-
cmake-version: ${{ env.CMAKE_VERSION }}
24-
2518

2619
- name: Generate solution
2720
shell: cmd

.github/workflows/build-win32.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,20 +19,13 @@ on:
1919
type: boolean
2020
default: false
2121

22-
env:
23-
CMAKE_VERSION: '3.31.6'
24-
2522
jobs:
2623
build:
2724
runs-on: windows-latest
2825
timeout-minutes: 60
2926
steps:
3027
- uses: actions/checkout@v5
3128

32-
- uses: jwlawson/actions-setup-cmake@v2
33-
with:
34-
cmake-version: ${{ env.CMAKE_VERSION }}
35-
3629

3730
- name: Set variables
3831
id: vars

.github/workflows/test-install-ios.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,20 +11,13 @@ on:
1111
type: string
1212
default: '16.4'
1313

14-
env:
15-
CMAKE_VERSION: '3.31.6'
16-
1714
jobs:
1815
test-install:
1916
runs-on: macos-latest
2017
timeout-minutes: 20
2118
steps:
2219
- uses: actions/checkout@v5
2320

24-
- uses: jwlawson/actions-setup-cmake@v2
25-
with:
26-
cmake-version: ${{ env.CMAKE_VERSION }}
27-
2821

2922
- name: Select Xcode ${{ inputs.xcode-version }}
3023
run: sudo xcode-select --switch /Applications/Xcode_${{ inputs.xcode-version }}.app/Contents/Developer

.github/workflows/test-install-linux.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,20 +3,13 @@ name: Test Install Linux
33
on:
44
workflow_call: {}
55

6-
env:
7-
CMAKE_VERSION: '3.31.6'
8-
96
jobs:
107
test-install:
118
runs-on: ubuntu-latest
129
timeout-minutes: 20
1310
steps:
1411
- uses: actions/checkout@v5
1512

16-
- uses: jwlawson/actions-setup-cmake@v2
17-
with:
18-
cmake-version: ${{ env.CMAKE_VERSION }}
19-
2013

2114
- name: Install packages
2215
run: |

.github/workflows/test-install-macos.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,20 +8,13 @@ on:
88
type: string
99
default: '16.4'
1010

11-
env:
12-
CMAKE_VERSION: '3.31.6'
13-
1411
jobs:
1512
test-install:
1613
runs-on: macos-latest
1714
timeout-minutes: 20
1815
steps:
1916
- uses: actions/checkout@v5
2017

21-
- uses: jwlawson/actions-setup-cmake@v2
22-
with:
23-
cmake-version: ${{ env.CMAKE_VERSION }}
24-
2518

2619
- name: Select Xcode ${{ inputs.xcode-version }}
2720
run: sudo xcode-select --switch /Applications/Xcode_${{ inputs.xcode-version }}.app/Contents/Developer

0 commit comments

Comments
 (0)