Remove obsolete CMake setup action; use runner-preinstalled cmake#1679
Merged
Conversation
jwlawson/actions-setup-cmake@v2 stopped resolving 3.31.6 today (the GitHub release still exists, but the action's version lookup no longer matches it). 3.31.8 is the latest 3.31.x patch and is still resolvable. Same issue / workaround as DynamoRIO/dynamorio#7872. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jwlawson/actions-setup-cmake@v2 fetches only the first 30 GitHub releases. With CMake's release cadence, neither 3.31.6 nor 3.31.8 are still in the first page; only 3.31.9-3.31.12 are. 3.31.12 is the latest 3.31.x patch. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bghgary
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the pinned CMake version used by GitHub Actions workflows to restore CI reliability after jwlawson/actions-setup-cmake@v2 stopped resolving 3.31.6 on fresh runners.
Changes:
- Bump
CMAKE_VERSIONfrom3.31.6to3.31.8across all affected workflows. - Keep workflows otherwise unchanged to minimize risk while unblocking CI.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/test-install-win32.yml | Updates workflow-level CMAKE_VERSION to a resolvable patch release. |
| .github/workflows/test-install-macos.yml | Updates workflow-level CMAKE_VERSION to a resolvable patch release. |
| .github/workflows/test-install-linux.yml | Updates workflow-level CMAKE_VERSION to a resolvable patch release. |
| .github/workflows/test-install-ios.yml | Updates workflow-level CMAKE_VERSION to a resolvable patch release. |
| .github/workflows/build-win32.yml | Updates workflow-level CMAKE_VERSION used by setup-cmake. |
| .github/workflows/build-win32-shader.yml | Updates workflow-level CMAKE_VERSION used by setup-cmake. |
| .github/workflows/build-uwp.yml | Updates workflow-level CMAKE_VERSION used by setup-cmake. |
| .github/workflows/build-macos.yml | Updates workflow-level CMAKE_VERSION used by setup-cmake. |
| .github/workflows/build-linux.yml | Updates workflow-level CMAKE_VERSION used by setup-cmake. |
| .github/workflows/build-ios.yml | Updates workflow-level CMAKE_VERSION used by setup-cmake. |
| .github/workflows/build-android.yml | Updates workflow-level CMAKE_VERSION used by setup-cmake. |
bghgary
changed the title
The pin existed because of cmake#22021 (macOS framework bug), fixed in CMake 3.22. Our minimum is 3.21 and runner images ship 3.30+, so the pin is obsolete. Today the jwlawson/actions-setup-cmake@v2 resolver started failing for all 3.31.x patches we tried; removing the action sidesteps that breakage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
CI started failing today on every fresh runner with:
from
jwlawson/actions-setup-cmake@v2. The GitHub release forv3.31.6still exists, and so do3.31.8and3.31.12, but the action's resolver can't find any of them right now. Bumping the pin to other 3.31.x patches did not help.Why the pin existed
The original Azure Pipelines
cmake.ymlscript (pre-#1661) had this comment:That CMake bug —
MACOSX_PACKAGE_LOCATIONmishandling forINTERFACE_SOURCES— was fixed in CMake 3.22 (MR!6698). The pin carried over into #1661 as part of the faithful Azure-→-Actions port.Why we don't need to pin anymore
CMakeLists.txtrequirescmake_minimum_required(VERSION 3.21).#22021bug we were avoiding is fixed in 3.22, well below anything any runner ships today.Change
Remove the
jwlawson/actions-setup-cmake@v2step (and itsCMAKE_VERSIONenv var) from all 11 workflow files. The runner-preinstalled CMake satisfies our minimum and avoids the broken action altogether.[Created by Copilot on behalf of @bghgary]