Re-enable blur-cube-with-the-effect-renderer validation test#1763
Open
bkaradzic-microsoft wants to merge 1 commit into
Open
Re-enable blur-cube-with-the-effect-renderer validation test#1763bkaradzic-microsoft wants to merge 1 commit into
bkaradzic-microsoft wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Re-enables the blur-cube-with-the-effect-renderer Playground validation test by removing its excludeFromAutomaticTesting entry, allowing it to run in the automated native validation suite.
Changes:
- Removed
excludeFromAutomaticTestingand associatedreasonforblur-cube-with-the-effect-rendererin the Playground validation catalog.
Comment on lines
2575
to
2579
| "title": "blur-cube-with-the-effect-renderer", | ||
| "playgroundId": "#4C900K#2", | ||
| "renderCount": 20, | ||
| "excludeFromAutomaticTesting": true, | ||
| "reason": "Pixel comparison fails (more than 20% pixels differ)", | ||
| "referenceImage": "blur-cube-with-the-effect-renderer.png" | ||
| }, |
This EffectRenderer fullscreen-pass test rendered all-black on Native because the native engine did not honor depth-test toggles made through engine.depthCullingState.depthTest (used by EffectRenderer). Fixed upstream in the native engine (BabylonJS/Babylon.js#18558); re-enable the test here. Depends on a babylonjs dependency bump that includes the fix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bkaradzic-microsoft
force-pushed
the
fix/reenable-blur-cube-effect-renderer
branch
from
1da8f15 to
067e50b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Re-enables the
blur-cube-with-the-effect-rendererPlayground validation test (#4C900K#2) by dropping itsexcludeFromAutomaticTestingentry inconfig.json.Split out of #1748 so it isn't blocked behind the texture-loader rework that PR is being re-scoped to.
Why it passes now
The test previously failed pixel comparison because the native engine ignored
depthCullingState.depthTest. That is fixed upstream by BabylonJS/Babylon.js#18558 ("[Native] Honor depthCullingState.depthTest on the native engine"), which has merged to Babylon.jsmaster.Gating
This re-enable is correct once the bundled
babylonjscontains #18558 — i.e. after a@babylonjs/corerelease that includes it and a Babylon Native pin bump. Until then the test still pixel-fails against the older bundled engine, so this should land alongside / after that bump.