Skip to content

Use BabylonNative WindowT type #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
CedricGuillemet wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Use BabylonNative WindowT type #708

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
65759fc
Use BabylonNative WindowT type
CedricGuillemet Mar 18, 2026
8f064d8
missed one def
CedricGuillemet Mar 18, 2026
d32fd42
Fix Xcode 26 build: suppress deprecated-declarations for Clang targets
CedricGuillemet Apr 14, 2026
3044eb1
Merge branch 'master' of https://github.com/babylonjs/BabylonReactNat…
CedricGuillemet Apr 14, 2026
b6ad45f
WindowType update
CedricGuillemet Apr 14, 2026
0a4d9b6
Add BABYLON_USE_SYSTEM_CMAKE env var and update version table
CedricGuillemet Apr 14, 2026
8721561
Fix missing CA::MetalLayer declaration in BabylonNative.h
CedricGuillemet Apr 14, 2026
267fb63
Fix CA::MetalLayer undeclared in C++ TUs via forward declaration
CedricGuillemet Apr 14, 2026
b2e1538
Fix ObjC CALayer* to C++ CA::MetalLayer* cast in BabylonNativeInterop.mm
CedricGuillemet Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Modules/@babylonjs/react-native/ios/BabylonNativeInterop.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ + (void)updateView:(MTKView*)mtkView {
const int width = static_cast<int>(mtkView.bounds.size.width * scale);
const int height = static_cast<int>(mtkView.bounds.size.height * scale);
if (width != 0 && height != 0) {
BabylonNative::UpdateView(mtkView, width, height);
BabylonNative::UpdateView(mtkView.layer, width, height);
Comment thread
CedricGuillemet marked this conversation as resolved.
Outdated
}
}

Expand Down
6 changes: 1 addition & 5 deletions Modules/@babylonjs/react-native/shared/BabylonNative.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,9 @@ namespace BabylonNative
Napi::Detach(m_env);
}

void UpdateView(WindowType window, size_t width, size_t height)
void UpdateView(Babylon::Graphics::WindowT window, size_t width, size_t height)
{
#if defined(__APPLE__)
m_graphicsConfig.Window = (Babylon::Graphics::WindowT)window.layer;
#else
m_graphicsConfig.Window = window;
#endif
m_graphicsConfig.Width = width;
m_graphicsConfig.Height = height;
UpdateGraphicsConfiguration();
Comment thread
CedricGuillemet marked this conversation as resolved.
Expand Down
2 changes: 1 addition & 1 deletion Modules/@babylonjs/react-native/shared/BabylonNative.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ namespace BabylonNative
void Initialize(facebook::jsi::Runtime& jsiRuntime, Dispatcher jsDispatcher);
void Deinitialize();

void UpdateView(WindowType window, size_t width, size_t height);
void UpdateView(Babylon::Graphics::WindowT window, size_t width, size_t height);
Comment thread
CedricGuillemet marked this conversation as resolved.
Outdated
void UpdateMSAA(uint8_t value);
void UpdateAlphaPremultiplied(bool enabled);

Expand Down
Loading