Skip to content

Commit 000f5c9

Browse files
bkaradzic-microsoftBranimir KaradžićCopilot
authored
Fix Windows CI: pin to windows-2022 (VS2022 toolset) (#192)
## Problem Every Windows/UWP build is failing. GitHub repointed the `windows-latest` label to a **VS2026** toolset (internal image `windows-2025-vs2026`). Its newer MSVC emits **C4875** (`a non-string literal argument to [[gsl::suppress]] is deprecated`) from inside the GSL headers we pull transitively via `arcana.cpp`, and our `/WX` builds promote it to a hard error. ## Fix Pin the Win32 and UWP jobs to the **windows-2022** runner, which still provides the established VS2022 toolset that doesn't emit C4875. This restores green CI with no source or dependency-graph change, and matches the approach taken in BabylonNative (BabylonJS/BabylonNative#1742). (Originally proposed as a GSL v4.2.2 bump / `/wd4875` suppression — see the closed #191 — but pinning the runner is the smaller, decoupled fix and keeps us on the known-good toolchain.) ## Validation CI on this branch confirms the Win32/UWP builds are green again on windows-2022. Co-authored-by: Branimir Karadžić <branimirk@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 5449381 commit 000f5c9

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/build-uwp.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ on:
1212

1313
jobs:
1414
build:
15-
runs-on: windows-latest
15+
runs-on: windows-2022
1616
timeout-minutes: 15
1717
steps:
1818
- uses: actions/checkout@v5

.github/workflows/build-win32.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ on:
1212

1313
jobs:
1414
build:
15-
runs-on: windows-latest
15+
runs-on: windows-2022
1616
timeout-minutes: 15
1717
steps:
1818
- uses: actions/checkout@v5

0 commit comments

Comments
 (0)